[binutils-gdb] [gdb/testsuite] Add regression test for PR32158

Tom de Vries vries@sourceware.org
Sat Sep 14 12:10:01 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=93a20d956e633cc1a87e68d88d2fc51adc787857

commit 93a20d956e633cc1a87e68d88d2fc51adc787857
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Sep 14 14:09:35 2024 +0200

    [gdb/testsuite] Add regression test for PR32158
    
    Consider test-case:
    ...
    namespace ns {
      enum class ec {
        val2 = 2
      };
    }
    
    int main () {
      return (int)ns::ec::val2;
    }
    ...
    compiled with debug info:
    ...
    $ g++ test.c -g
    ...
    
    When looking at the cooked index entry for val2 using "maint print objfiles",
    we get:
    ...
        [7] ((cooked_index_entry *) 0x7f8ecc002ef0)
        name:       val2
        canonical:  val2
        qualified:  ns::val2
        DWARF tag:  DW_TAG_enumerator
        flags:      0x0 []
        DIE offset: 0xe9
        parent:     ((cooked_index_entry *) 0x7f8ecc002e90) [ns]
    ...
    which is wrong, there is no source level entity ns::val2.
    
    This is PR symtab/32158.
    
    This is a regression since commit 4e417d7bb1c ("Change handling of
    DW_TAG_enumeration_type in DWARF scanner").
    
    Reverting the commit on current trunk fixes the problem, and gets us instead:
    ...
        [7] ((cooked_index_entry *) 0x7fba70002ef0)
        name:       val2
        canonical:  val2
        qualified:  ns::ec::val2
        DWARF tag:  DW_TAG_enumerator
        flags:      0x0 []
        DIE offset: 0xe9
        parent:     ((cooked_index_entry *) 0x7fba70002ec0) [ec]
    ...
    
    Add a regression test for this PR in test-case gdb.dwarf2/enum-type-c++.exp.
    
    Tested on x86_64-linux.
    
    Approved-By: Tom Tromey <tom@tromey.com>
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32158

Diff:
---
 gdb/testsuite/gdb.dwarf2/enum-type-c++.cc  |  6 ++++++
 gdb/testsuite/gdb.dwarf2/enum-type-c++.exp | 12 ++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/gdb/testsuite/gdb.dwarf2/enum-type-c++.cc b/gdb/testsuite/gdb.dwarf2/enum-type-c++.cc
index c0ffaad0316..691c7fc7d88 100644
--- a/gdb/testsuite/gdb.dwarf2/enum-type-c++.cc
+++ b/gdb/testsuite/gdb.dwarf2/enum-type-c++.cc
@@ -24,6 +24,12 @@ public:
   };
 };
 
+enum class ec
+{
+  val2 = 2,
+};
 }
 
 int u1 = ns::A::val1;
+
+int u2 = (int)ns::ec::val2;
diff --git a/gdb/testsuite/gdb.dwarf2/enum-type-c++.exp b/gdb/testsuite/gdb.dwarf2/enum-type-c++.exp
index 44ad225de02..a3dfb4d2f74 100644
--- a/gdb/testsuite/gdb.dwarf2/enum-type-c++.exp
+++ b/gdb/testsuite/gdb.dwarf2/enum-type-c++.exp
@@ -42,3 +42,15 @@ gdb_test_lines "maint print objfiles" \
 	 ".*"]
 
 gdb_test "print $val1" " = $val1"
+
+# Regression test for PR32158.
+setup_kfail "gdb/32158" *-*-*
+set val2 ns::ec::val2
+gdb_test_lines "maint print objfiles" \
+    "val2 has correct parent" \
+    [multi_line \
+	 "" \
+	 "$re_ws+qualified:$re_ws+$val2" \
+	 ".*"]
+
+gdb_test "print $val2" " = $val2"


More information about the Gdb-cvs mailing list