[binutils-gdb] gdb/dap: allow some requests when the process is running

Tom Tromey tromey@sourceware.org
Fri Dec 13 16:48:56 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7336a8977d81b7b8c00f2e8ccb8a084afb33b19a

commit 7336a8977d81b7b8c00f2e8ccb8a084afb33b19a
Author: oltolm <oleg.tolmatcev@gmail.com>
Date:   Sun Nov 24 18:39:13 2024 +0100

    gdb/dap: allow some requests when the process is running
    
    It is impossible to set a breakpoint when the process is running,
    which I find annoying. LLDB does not have this restriction. I made
    `setBreakpoints` and `breakpointLocations` work when the process is
    running. Probably more requests can be changed, but I only need these
    two at the moment.
    
    Approved-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/python/lib/gdb/dap/breakpoint.py | 2 +-
 gdb/python/lib/gdb/dap/locations.py  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/python/lib/gdb/dap/breakpoint.py b/gdb/python/lib/gdb/dap/breakpoint.py
index 15055f21b7b..6adb826d223 100644
--- a/gdb/python/lib/gdb/dap/breakpoint.py
+++ b/gdb/python/lib/gdb/dap/breakpoint.py
@@ -288,7 +288,7 @@ def _rewrite_src_breakpoint(
     }
 
 
-@request("setBreakpoints")
+@request("setBreakpoints", expect_stopped=False)
 @capability("supportsHitConditionalBreakpoints")
 @capability("supportsConditionalBreakpoints")
 @capability("supportsLogPoints")
diff --git a/gdb/python/lib/gdb/dap/locations.py b/gdb/python/lib/gdb/dap/locations.py
index 967322fbeaf..befb7bf2575 100644
--- a/gdb/python/lib/gdb/dap/locations.py
+++ b/gdb/python/lib/gdb/dap/locations.py
@@ -28,7 +28,7 @@ from .startup import exec_mi_and_log
 # This points out that fixing this would be an incompatibility but
 # goes on to propose "if arguments property is missing, debug adapters
 # should return an error".
-@request("breakpointLocations")
+@request("breakpointLocations", expect_stopped=False)
 @capability("supportsBreakpointLocationsRequest")
 def breakpoint_locations(*, source, line: int, endLine: Optional[int] = None, **extra):
     if endLine is None:


More information about the Gdb-cvs mailing list