[binutils-gdb] testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior

Abdul Basit Ijaz abijaz@sourceware.org
Mon Sep 11 15:17:44 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2e2d1ccdc5b66fcb765c7efd2b6ba58c9932697e

commit 2e2d1ccdc5b66fcb765c7efd2b6ba58c9932697e
Author: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Date:   Fri Sep 8 22:56:18 2023 +0200

    testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior
    
    Got a regression email due to merge of commit in CI config
    tcwg_gdb_check/master-aarch64 :
    https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185cd0075bbb1aedf9665685dba0827cfec
    
    Begining of test "gdb.fortran/array-slices-bad.exp" was updated in above
    commit to start the test from running to line with tag "First Breakpoint"
    instead of "fortran_runto_main".  Reason of the regression is shared
    libraries are still loaded after hitting the breakpoint as "nosharedlibrary"
    is already called before hitting the breakpoint.
    
    So now after this change test is updated accordingly to disable and unload
    shared libraries symbols after hitting the first breakpoint.
    
    Approved-By: Andrew Burgess <aburgess@redhat.com>

Diff:
---
 gdb/testsuite/gdb.fortran/array-slices-bad.exp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/array-slices-bad.exp b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
index d7b00694539..280628db1b4 100644
--- a/gdb/testsuite/gdb.fortran/array-slices-bad.exp
+++ b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
@@ -25,17 +25,17 @@ if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
     return -1
 }
 
+if {![runto [gdb_get_line_number "First Breakpoint"]]} {
+    perror "couldn't run to breakpoint First Breakpoint"
+    return -1
+}
+
 # Avoid shared lib symbols.
 gdb_test_no_output "set auto-solib-add off"
 
 # Avoid libc symbols, in particular the 'array' type.
 gdb_test_no_output "nosharedlibrary"
 
-if {![runto [gdb_get_line_number "First Breakpoint"]]} {
-    perror "couldn't run to breakpoint First Breakpoint"
-    return -1
-}
-
 gdb_breakpoint [gdb_get_line_number "Second Breakpoint"]
 gdb_breakpoint [gdb_get_line_number "Final Breakpoint"]


More information about the Gdb-cvs mailing list