[binutils-gdb] Remove dead code from varobj_set_display_format

Tom Tromey tromey@sourceware.org
Thu Sep 7 20:06:05 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=665b55a92ed514d4eb32f78278dd7f0e39865f04

commit 665b55a92ed514d4eb32f78278dd7f0e39865f04
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Aug 31 12:11:46 2023 -0600

    Remove dead code from varobj_set_display_format
    
    varobj_set_display_format takes an enum and exhaustively switches on
    the values -- but also has a default.  This default case is dead code.
    
    Reviewed-by: Keith Seitz <keiths@redhat.com>

Diff:
---
 gdb/varobj.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/gdb/varobj.c b/gdb/varobj.c
index 52e62aca265..760809c6f51 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -488,20 +488,7 @@ enum varobj_display_formats
 varobj_set_display_format (struct varobj *var,
 			   enum varobj_display_formats format)
 {
-  switch (format)
-    {
-    case FORMAT_NATURAL:
-    case FORMAT_BINARY:
-    case FORMAT_DECIMAL:
-    case FORMAT_HEXADECIMAL:
-    case FORMAT_OCTAL:
-    case FORMAT_ZHEXADECIMAL:
-      var->format = format;
-      break;
-
-    default:
-      var->format = variable_default_display (var);
-    }
+  var->format = format;
 
   if (varobj_value_is_changeable_p (var) 
       && var->value != nullptr && !var->value->lazy ())


More information about the Gdb-cvs mailing list