[binutils-gdb] gdb: fix build of darwin-nat.c

Simon Marchi simark@sourceware.org
Tue Nov 21 16:45:31 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=790ce1f70c25129b35e060329cdf2915a6def9fd

commit 790ce1f70c25129b35e060329cdf2915a6def9fd
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Tue Nov 21 11:42:41 2023 -0500

    gdb: fix build of darwin-nat.c
    
    Patch 743877128 ("gdb: remove regcache's address space") changed the
    signature of darwin_nat_target::cancel_breakpoint, but missing updating
    the class declaration, resulting in:
    
          CXX    darwin-nat.o
        /Users/smarchi/src/binutils-gdb/gdb/darwin-nat.c:1154:20: error: out-of-line definition of 'cancel_breakpoint' does not match any declaration in 'darwin_nat_target'
        darwin_nat_target::cancel_breakpoint (inferior *inf, ptid_t ptid)
                           ^~~~~~~~~~~~~~~~~
        /Users/smarchi/src/binutils-gdb/gdb/darwin-nat.c:1290:9: error: too many arguments to function call, expected single argument 'ptid', have 2 arguments
                                            ptid_t (inf->pid, 0, thread->gdb_port)))
                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /Users/smarchi/src/binutils-gdb/gdb/darwin-nat.h:129:7: note: 'cancel_breakpoint' declared here
          int cancel_breakpoint (ptid_t ptid);
              ^
    
    Fix that.
    
    Change-Id: Iedd58b36777eb77bca9e23f94882b217c9c87059

Diff:
---
 gdb/darwin-nat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h
index 4dd8078fe31..1b785496570 100644
--- a/gdb/darwin-nat.h
+++ b/gdb/darwin-nat.h
@@ -126,7 +126,7 @@ private:
   void stop_inferior (inferior *inf);
   void init_thread_list (inferior *inf);
   void ptrace_him (int pid);
-  int cancel_breakpoint (ptid_t ptid);
+  int cancel_breakpoint (inferior *inf, ptid_t ptid);
 };
 
 /* Describe the mach exception handling state for a task.  This state is saved


More information about the Gdb-cvs mailing list