[binutils-gdb] gdb: Remove extra if statement

Christina Schimpe cschimpe@sourceware.org
Fri Mar 31 14:25:24 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=85413975d80cdb69efd09211d01fc96e00a84dd0

commit 85413975d80cdb69efd09211d01fc96e00a84dd0
Author: Ari Hannula <ari.hannula@intel.com>
Date:   Mon May 16 13:43:31 2022 +0200

    gdb: Remove extra if statement
    
    The removed if statement is already checked in the parent if else
    statement.
    
    Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>

Diff:
---
 gdb/thread.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/gdb/thread.c b/gdb/thread.c
index 3d4cba32303..25d97cd6072 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1083,16 +1083,13 @@ print_thread_info_1 (struct ui_out *uiout, const char *requested_threads,
 				      global_ids, pid, tp))
 	      continue;
 
-	    if (!uiout->is_mi_like_p ())
-	      {
-		/* Switch inferiors so we're looking at the right
-		   target stack.  */
-		switch_to_inferior_no_thread (tp->inf);
-
-		target_id_col_width
-		  = std::max (target_id_col_width,
-			      thread_target_id_str (tp).size ());
-	      }
+	    /* Switch inferiors so we're looking at the right
+	       target stack.  */
+	    switch_to_inferior_no_thread (tp->inf);
+
+	    target_id_col_width
+	      = std::max (target_id_col_width,
+			  thread_target_id_str (tp).size ());
 
 	    ++n_threads;
 	  }


More information about the Gdb-cvs mailing list