[binutils-gdb] gdb/python: remove unneeded nullptr check in frapy_block

Andrew Burgess aburgess@sourceware.org
Thu Mar 30 09:26:02 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3194ca90fefda8e3e43cb11cb149a1e5c074d45c

commit 3194ca90fefda8e3e43cb11cb149a1e5c074d45c
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Thu Mar 9 09:11:35 2023 +0000

    gdb/python: remove unneeded nullptr check in frapy_block
    
    Spotted a redundant nullptr check in python/py-frame.c in the function
    frapy_block.  This was introduced in commit 57126e4a45e3000e when we
    expanded an earlier check in return early if the pointer in question
    is nullptr.
    
    There should be no user visible changes after this commit.
    
    Reviewed-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/python/py-frame.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c
index ecd55d2e568..00cd4bee492 100644
--- a/gdb/python/py-frame.c
+++ b/gdb/python/py-frame.c
@@ -304,13 +304,7 @@ frapy_block (PyObject *self, PyObject *args)
       return NULL;
     }
 
-  if (block)
-    {
-      return block_to_block_object
-	(block, fn_block->function ()->objfile ());
-    }
-
-  Py_RETURN_NONE;
+  return block_to_block_object (block, fn_block->function ()->objfile ());
 }


More information about the Gdb-cvs mailing list