[binutils-gdb] [gdb/dap] Add logging of ignored lines

Tom de Vries vries@sourceware.org
Fri Mar 24 08:08:15 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8ee55b880fbabe0a20bf4adc1ba68307ba8a02be

commit 8ee55b880fbabe0a20bf4adc1ba68307ba8a02be
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Mar 24 09:08:10 2023 +0100

    [gdb/dap] Add logging of ignored lines
    
    This input sequence is accepted by DAP:
    ...
    {"seq": 4, "type": "request", "command": "configurationDone"}Content-Length: 84
    ...
    
    This input sequence has the same effect:
    ...
    {"seq": 4, "type": "request", "command": "configurationDone"}ignorethis
    Content-Length: 84
    ...
    but the 'ignorethis' part is silently ignored.
    
    Log the ignored bit, such that we have:
    ...
    READ: <<<{"seq": 4, "type": "request", "command": "configurationDone"}>>>
    WROTE: <<<{"request_seq": 4, "type": "response", "command": "configurationDone"
    , "success": true}>>>
    +++ run
    IGNORED: <<<b'ignorethis'>>>
    ...

Diff:
---
 gdb/python/lib/gdb/dap/io.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/python/lib/gdb/dap/io.py b/gdb/python/lib/gdb/dap/io.py
index 74cc82301d7..7cec7b032e3 100644
--- a/gdb/python/lib/gdb/dap/io.py
+++ b/gdb/python/lib/gdb/dap/io.py
@@ -15,7 +15,7 @@
 
 import json
 
-from .startup import start_thread, send_gdb
+from .startup import start_thread, send_gdb, log
 
 
 def read_json(stream):
@@ -31,6 +31,8 @@ def read_json(stream):
         if line.startswith(b"Content-Length:"):
             line = line[15:].strip()
             content_length = int(line)
+            continue
+        log("IGNORED: <<<%s>>>" % line)
     data = bytes()
     while len(data) < content_length:
         new_data = stream.read(content_length - len(data))


More information about the Gdb-cvs mailing list