[binutils-gdb] [gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host

Tom de Vries vries@sourceware.org
Mon Mar 13 16:20:50 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7fee66abd3fd69a0c4dc6c8dcd9aa49eede3864e

commit 7fee66abd3fd69a0c4dc6c8dcd9aa49eede3864e
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 13 17:20:09 2023 +0100

    [gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host
    
    When running gdb.python/tui-window.exp with host board
    local-remote-host-notty and target board native-gdbserver, I get:
    ...
    FAIL: gdb.python/tui-window-factory.exp: msg_2: \
      check test_window box (box check: ul corner is l, not +)
    ...
    
    The problem is that the result of Term::prepare_for_tui is not checked.
    
    Fix this by adding the missing check.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.python/tui-window-factory.exp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.python/tui-window-factory.exp b/gdb/testsuite/gdb.python/tui-window-factory.exp
index 3e898d01c7b..e3b403bdea0 100644
--- a/gdb/testsuite/gdb.python/tui-window-factory.exp
+++ b/gdb/testsuite/gdb.python/tui-window-factory.exp
@@ -32,7 +32,10 @@ set pyfile [gdb_remote_download host \
 		${srcdir}/${subdir}/${gdb_test_file_name}.py]
 
 Term::clean_restart 24 80
-Term::prepare_for_tui
+if { ![Term::prepare_for_tui] } {
+    unsupported "TUI not supported"
+    return
+}
 
 gdb_test "source ${pyfile}" "Python script imported" \
     "import python scripts"


More information about the Gdb-cvs mailing list