[binutils-gdb] [gdb/testsuite] Fix gdb.server/unittest.exp for remote target

Tom de Vries vries@sourceware.org
Thu Mar 9 09:45:27 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b40b8facd5971bf12040c1fd483a104e736d9f56

commit b40b8facd5971bf12040c1fd483a104e736d9f56
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Mar 9 10:45:03 2023 +0100

    [gdb/testsuite] Fix gdb.server/unittest.exp for remote target
    
    With test-case gdb.server/unittest.exp and a build with --disable-unit-tests I
    get:
    ...
    (gdb) builtin_spawn /data/vries/gdb/leap-15-4/build/gdbserver/gdbserver \
      --selftest^M
    Selftests have been disabled for this build.^M
    UNSUPPORTED: gdb.server/unittest.exp: unit tests
    ...
    but with target board remote-stdio-gdbserver I get instead:
    ...
    (gdb) builtin_spawn /usr/bin/ssh -t -l vries localhost \
      /data/vries/gdb/leap-15-4/build/gdbserver/gdbserver --selftest^M
    Selftests have been disabled for this build.^M
    Connection to localhost closed.^M^M
    FAIL: gdb.server/unittest.exp: unit tests
    ...
    
    Fix this by making the regexp less strict.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.server/unittest.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.server/unittest.exp b/gdb/testsuite/gdb.server/unittest.exp
index d25ee362644..2ef2865a11a 100644
--- a/gdb/testsuite/gdb.server/unittest.exp
+++ b/gdb/testsuite/gdb.server/unittest.exp
@@ -36,7 +36,7 @@ expect {
 	gdb_assert "$num_ran >= 0" $test
     }
 
-    -re "Selftests have been disabled for this build.\r\n$" {
+    -re "Selftests have been disabled for this build.\r\n" {
 	unsupported $test
     }


More information about the Gdb-cvs mailing list