[binutils-gdb] Fix btrace regression

Tom Tromey tromey@sourceware.org
Wed Mar 1 13:38:43 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8b2d5ef8d41e8da46d8b138ea7d7fe3eb5d4a221

commit 8b2d5ef8d41e8da46d8b138ea7d7fe3eb5d4a221
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Feb 28 18:43:01 2023 -0700

    Fix btrace regression
    
    Tom de Vries pointed out that my earlier patch:
    
        commit 873a185be258ad2552b9579005852815b4da5baf
        Date:   Fri Dec 16 07:56:57 2022 -0700
    
            Don't use struct buffer in handle_qxfer_btrace
    
    regressed gdb.btrace/reconnect.exp.  I didn't notice this because I
    did not have libipt installed.
    
    This patch fixes the bug.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169
    Tested-By: Bruno Larsen <blarsen@redhat.com>

Diff:
---
 gdbserver/linux-low.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index dec1944d45f..0ca3bb1cd6a 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -6781,7 +6781,7 @@ linux_low_encode_raw (std::string *buffer, const gdb_byte *data,
       elem[0] = tohex ((*data >> 4) & 0xf);
       elem[1] = tohex (*data++ & 0xf);
 
-      buffer->append (elem);
+      buffer->append (elem, 2);
     }
 
   *buffer += "</raw>\n";


More information about the Gdb-cvs mailing list