[binutils-gdb] [gdb/testsuite] Use require in gdb.dwarf2/implptr.exp

Tom de Vries vries@sourceware.org
Sat Jun 17 10:29:12 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=09ea7c9c49ec1a94c8107cd2c1dd303d158b218d

commit 09ea7c9c49ec1a94c8107cd2c1dd303d158b218d
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Jun 17 12:28:58 2023 +0200

    [gdb/testsuite] Use require in gdb.dwarf2/implptr.exp
    
    In test-case gdb.dwarf2/implptr.exp I noticed:
    ...
    } elseif {![is_x86_like_target]} {
        # This test can only be run on x86 targets.
        unsupported "needs x86-like target"
        return 0
    }
    ...
    
    Use instead "require is_x86_like_target".
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.dwarf2/implptr.exp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/implptr.exp b/gdb/testsuite/gdb.dwarf2/implptr.exp
index 70d86ddf19a..71fb1e443ef 100644
--- a/gdb/testsuite/gdb.dwarf2/implptr.exp
+++ b/gdb/testsuite/gdb.dwarf2/implptr.exp
@@ -19,6 +19,9 @@ load_lib dwarf.exp
 # This test can only be run on targets which support DWARF-2 and use gas.
 require dwarf2_support
 
+# This test can only be run on x86 targets.
+require is_x86_like_target
+
 standard_testfile .S
 set csrcfile ${testfile}.c
 set opts {}
@@ -27,10 +30,6 @@ if [info exists COMPILE] {
     # make check RUNTESTFLAGS='gdb.dwarf2/implptr.exp COMPILE=1 CC_FOR_TARGET=gcc\ -m32'
     set srcfile ${csrcfile}
     lappend opts debug optimize=-O2
-} elseif {![is_x86_like_target]} {
-    # This test can only be run on x86 targets.
-    unsupported "needs x86-like target"
-    return 0  
 }
 
 if {[prepare_for_testing "failed to prepare" ${testfile} $srcfile $opts]} {


More information about the Gdb-cvs mailing list