[binutils-gdb] gdb: boolify 'should_print_thread'

Tankut Baris Aktemur aktemur@sourceware.org
Wed Apr 5 06:26:53 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9278aa6171edd477326f1a73a112d98b8b785954

commit 9278aa6171edd477326f1a73a112d98b8b785954
Author: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Date:   Wed Apr 5 08:23:56 2023 +0200

    gdb: boolify 'should_print_thread'
    
    Convert the return type of 'should_print_thread' from int to bool.
    
    Reviewed-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/thread.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/thread.c b/gdb/thread.c
index 1c664bc3ab5..4d97ed3f2d1 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -961,7 +961,7 @@ pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread)
    and PID is not -1, then the thread is printed if it belongs to the
    specified process.  Otherwise, an error is raised.  */
 
-static int
+static bool
 should_print_thread (const char *requested_threads, int default_inf_num,
 		     int global_ids, int pid, struct thread_info *thr)
 {
@@ -975,20 +975,20 @@ should_print_thread (const char *requested_threads, int default_inf_num,
 	in_list = tid_is_in_list (requested_threads, default_inf_num,
 				  thr->inf->num, thr->per_inf_num);
       if (!in_list)
-	return 0;
+	return false;
     }
 
   if (pid != -1 && thr->ptid.pid () != pid)
     {
       if (requested_threads != NULL && *requested_threads != '\0')
 	error (_("Requested thread not found in requested process"));
-      return 0;
+      return false;
     }
 
   if (thr->state == THREAD_EXITED)
-    return 0;
+    return false;
 
-  return 1;
+  return true;
 }
 
 /* Return the string to display in "info threads"'s "Target Id"


More information about the Gdb-cvs mailing list