[binutils-gdb] sim: Initialize pbb_br_* by default

Andrew Burgess aburgess@sourceware.org
Tue Oct 11 14:19:36 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=babcfd75883790c13de37c86f15de7d4bca582de

commit babcfd75883790c13de37c86f15de7d4bca582de
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Thu Oct 6 06:43:53 2022 +0000

    sim: Initialize pbb_br_* by default
    
    On the files generated by sim/common/genmloop.sh, variables pbb_br_type and
    pbb_br_npc are declared uninitialized and passed to other functions in some
    cases.  Despite that those are harmless, they will generate GCC warnings
    ("-Wmaybe-uninitialized").
    
    This commit ensures that pbb_br_type and pbb_br_npc variables are
    initialized to a harmless value.

Diff:
---
 sim/common/genmloop.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sim/common/genmloop.sh b/sim/common/genmloop.sh
index 1bbeb615b05..5f6456d7159 100755
--- a/sim/common/genmloop.sh
+++ b/sim/common/genmloop.sh
@@ -1167,8 +1167,8 @@ void
   SEM_PC vpc;
 #if WITH_SEM_SWITCH_FULL
   /* For communication between cti's and cti-chain.  */
-  SEM_BRANCH_TYPE pbb_br_type;
-  PCADDR pbb_br_npc;
+  SEM_BRANCH_TYPE pbb_br_type = SEM_BRANCH_UNTAKEN;
+  PCADDR pbb_br_npc = 0;
 #endif
 
 EOF
@@ -1259,8 +1259,8 @@ void
   SEM_PC vpc;
 #if WITH_SEM_SWITCH_FAST
   /* For communication between cti's and cti-chain.  */
-  SEM_BRANCH_TYPE pbb_br_type;
-  PCADDR pbb_br_npc;
+  SEM_BRANCH_TYPE pbb_br_type = SEM_BRANCH_UNTAKEN;
+  PCADDR pbb_br_npc = 0;
 #endif
 
 EOF


More information about the Gdb-cvs mailing list