[binutils-gdb] gdbserver: Fixup previous patch

Pedro Alves palves@sourceware.org
Mon Mar 21 17:01:56 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4414150d33212f5f395c3bf8a940bccf80ffc508

commit 4414150d33212f5f395c3bf8a940bccf80ffc508
Author: Pedro Alves <pedro@palves.net>
Date:   Mon Mar 21 16:58:23 2022 +0000

    gdbserver: Fixup previous patch
    
    The previous prepare_resume_reply change missed updating the 'buf'
    reference that overwrites the 'T', so if 'buf' was advanced, we'd
    still overwrite the wrong character.  This fixes it.
    
    Change-Id: Ia8ce433366b85af4e268c1c49e7b447da3130a4d

Diff:
---
 gdbserver/remote-utils.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc
index 0599cc9c4f1..db9b2a66f3c 100644
--- a/gdbserver/remote-utils.cc
+++ b/gdbserver/remote-utils.cc
@@ -1144,7 +1144,7 @@ prepare_resume_reply (char *buf, ptid_t ptid, const target_waitstatus &status)
 	    gdb_assert (buf_start[0] == 'T');
 	    gdb_assert (isxdigit (buf_start[1]));
 	    gdb_assert (isxdigit (buf_start[2]));
-	    *buf = 'S';
+	    buf_start[0] = 'S';
 	    buf_start[3] = '\0';
 	    break;
 	  }


More information about the Gdb-cvs mailing list