[binutils-gdb] gdb: use a range based for loop when iterating over an array

Andrew Burgess aburgess@sourceware.org
Thu Feb 24 16:39:49 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dd1ae8eaa369ac5c7df7e55c929b42ac8ac44526

commit dd1ae8eaa369ac5c7df7e55c929b42ac8ac44526
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Nov 30 14:18:09 2021 +0000

    gdb: use a range based for loop when iterating over an array
    
    Make use of a range based for loop to iterate over a static global
    array, removing the need to have a null entry at the end of the
    array.
    
    There should be no user visible changes after this commit.

Diff:
---
 gdb/python/py-type.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
index 8613534d060..13dae1e2559 100644
--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -113,7 +113,6 @@ static struct pyty_code pyty_codes[] =
   ENTRY (TYPE_CODE_NAMESPACE),
   ENTRY (TYPE_CODE_DECFLOAT),
   ENTRY (TYPE_CODE_INTERNAL_FUNCTION),
-  { TYPE_CODE_UNDEF, NULL }
 };
 
 

@@ -1445,8 +1444,6 @@ _initialize_py_type ()
 int
 gdbpy_initialize_types (void)
 {
-  int i;
-
   if (PyType_Ready (&type_object_type) < 0)
     return -1;
   if (PyType_Ready (&field_object_type) < 0)
@@ -1454,10 +1451,9 @@ gdbpy_initialize_types (void)
   if (PyType_Ready (&type_iterator_object_type) < 0)
     return -1;
 
-  for (i = 0; pyty_codes[i].name; ++i)
+  for (const auto &item : pyty_codes)
     {
-      if (PyModule_AddIntConstant (gdb_module, pyty_codes[i].name,
-				   pyty_codes[i].code) < 0)
+      if (PyModule_AddIntConstant (gdb_module, item.name, item.code) < 0)
 	return -1;
     }


More information about the Gdb-cvs mailing list