[binutils-gdb] sim: ppc: fix Wnonnull warning
Tom de Vries
vries@sourceware.org
Wed May 19 16:43:02 GMT 2021
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bfff0efb3d8283a48825abc1701bb39a56d223c5
commit bfff0efb3d8283a48825abc1701bb39a56d223c5
Author: Tom de Vries <tdevries@suse.de>
Date: Wed May 19 18:42:59 2021 +0200
sim: ppc: fix Wnonnull warning
When compiling with --enable-werror and CFLAGS="-O0 -g -Wall", we run into:
...
src/sim/ppc/emul_netbsd.c: In function 'do_gettimeofday':
src/sim/ppc/emul_netbsd.c:770:16: error: null argument where non-null \
required (argument 1) [-Werror=nonnull]
int status = gettimeofday((t_addr != 0 ? &t : NULL),
^~~~~~~~~~~~
...
Fix this by unconditionally passing &t as first argument.
Diff:
---
sim/ppc/emul_netbsd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sim/ppc/emul_netbsd.c b/sim/ppc/emul_netbsd.c
index 0135a93298b..4d9f32d52be 100644
--- a/sim/ppc/emul_netbsd.c
+++ b/sim/ppc/emul_netbsd.c
@@ -767,8 +767,7 @@ do_gettimeofday(os_emul_data *emul,
unsigned_word tz_addr = cpu_registers(processor)->gpr[arg0+1];
struct timeval t;
struct timezone tz;
- int status = gettimeofday((t_addr != 0 ? &t : NULL),
- (tz_addr != 0 ? &tz : NULL));
+ int status = gettimeofday(&t, (tz_addr != 0 ? &tz : NULL));
int err = errno;
if (WITH_TRACE && ppc_trace[trace_os_emul])
More information about the Gdb-cvs
mailing list