[binutils-gdb] testsuite, gdb.btrace: remove assembly-check in delta.exp

Markus Metzger mmetzger@sourceware.org
Wed Mar 3 08:20:28 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e71dbd03045836f8a604ccc2ac709823479110cc

commit e71dbd03045836f8a604ccc2ac709823479110cc
Author: Markus Metzger <markus.t.metzger@intel.com>
Date:   Tue Dec 15 12:46:58 2020 +0100

    testsuite, gdb.btrace: remove assembly-check in delta.exp
    
    In gdb.btrace/delta.exp, we test that we do not extend the trace
    unintentionally.  This can be tested by checking the number of
    instructions.
    
    If we wanted to check the instruction history, as well, we'd need to work
    on an assembly file to have deterministic behaviour.  This isn't really
    necessary for this test, however, and covered elsewhere.  Also remove the
    function call history check for the same reason.

Diff:
---
 gdb/testsuite/ChangeLog            | 5 +++++
 gdb/testsuite/gdb.btrace/delta.exp | 9 +--------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9bc6995aa87..1f0941e13e1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-03-03  Markus Metzger  <markus.t.metzger@intel.com>
+
+	* gdb.btrace/delta.exp: Remove instruction-history and
+	function-call-history checks.
+
 2021-03-03  Markus Metzger  <markus.t.metzger@intel.com>
 
 	* README (Note): Add nopie_ldflag.
diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrace/delta.exp
index 9f6d741c013..0d61e9aa54e 100644
--- a/gdb/testsuite/gdb.btrace/delta.exp
+++ b/gdb/testsuite/gdb.btrace/delta.exp
@@ -58,9 +58,6 @@ proc check_trace {} {
     "Recording format: .*" \
     "Recorded 1 instructions in 1 functions \\\(0 gaps\\\) for .*" \
     ]
-  gdb_test "record instruction-history /f 1" \
-    "1\t   0x\[0-9a-f\]+ <\\+\[0-9\]+>:\tmov *\\\$0x0,%eax\r"
-  gdb_test "record function-call-history /c 1" "1\tmain"
 }
 
 # make sure we don't extend the trace when we ask twice.
@@ -86,9 +83,5 @@ with_test_prefix "reverse" {
 # and back
 with_test_prefix "forward" {
     gdb_test "stepi"
-    gdb_test "info record" [multi_line \
-      "Active record target: record-btrace" \
-      "Recording format: .*" \
-      "Recorded 1 instructions in 1 functions \\\(0 gaps\\\) for .*" \
-    ]
+    check_trace
 }


More information about the Gdb-cvs mailing list