[binutils-gdb] sim: use -Wunused-but-set-parameter

[Michael Frysinger]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7f6fa743740e63fa7ecfd35845853ec6814d0500

commit 7f6fa743740e63fa7ecfd35845853ec6814d0500
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Tue Jun 29 21:05:17 2021 -0400

    sim: use -Wunused-but-set-parameter
    
    The code is already clean, so sync this over from gdb warning.m4.
    Also shuffle the order of the flags a bit to match the current gdb
    warning.m4 code.

Diff:
---
 sim/ChangeLog                    |  5 +++++
 sim/configure                    | 16 ++++++++++------
 sim/m4/sim_ac_option_warnings.m4 | 16 ++++++++++------
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/sim/ChangeLog b/sim/ChangeLog
index 959d3582da1..59c123de79c 100644
--- a/sim/ChangeLog
+++ b/sim/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-29  Mike Frysinger  <vapier@gentoo.org>
+
+	* m4/sim_ac_option_warnings.m4: Add -Wunused-but-set-parameter.
+	* configure: Regenerate.
+
 2021-06-29  Mike Frysinger  <vapier@gentoo.org>
 
 	* m4/sim_ac_option_warnings.m4: Add -Wno-error=maybe-uninitialized.
diff --git a/sim/configure b/sim/configure
index 3120006e6d5..94b45fd5f18 100755
--- a/sim/configure
+++ b/sim/configure
@@ -14584,13 +14584,17 @@ if test "${ERROR_ON_WARNING}" = yes ; then
   WERROR_CFLAGS="-Werror"
 fi
 
-build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
--Wpointer-sign \
--Wno-unused -Wunused-value -Wunused-function \
--Wno-switch -Wno-char-subscripts -Wmissing-prototypes
+build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith
+-Wno-unused -Wunused-value -Wunused-function
+-Wno-switch -Wno-char-subscripts
+-Wempty-body -Wunused-but-set-parameter
 -Wno-error=maybe-uninitialized
--Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type \
--Wold-style-declaration -Wold-style-definition"
+-Wmissing-declarations
+-Wmissing-prototypes
+-Wdeclaration-after-statement -Wmissing-parameter-type
+-Wpointer-sign
+-Wold-style-declaration -Wold-style-definition
+"
 
 # Enable -Wno-format by default when using gcc on mingw since many
 # GCC versions complain about %I64.
diff --git a/sim/m4/sim_ac_option_warnings.m4 b/sim/m4/sim_ac_option_warnings.m4
index 05c77f1b92d..4deacc1b958 100644
--- a/sim/m4/sim_ac_option_warnings.m4
+++ b/sim/m4/sim_ac_option_warnings.m4
@@ -37,13 +37,17 @@ fi
 
 dnl The options we'll try to enable.
 dnl NB: Kept somewhat in sync with gdbsupport/warnings.m4.
-build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
--Wpointer-sign \
--Wno-unused -Wunused-value -Wunused-function \
--Wno-switch -Wno-char-subscripts -Wmissing-prototypes
+build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith
+-Wno-unused -Wunused-value -Wunused-function
+-Wno-switch -Wno-char-subscripts
+-Wempty-body -Wunused-but-set-parameter
 -Wno-error=maybe-uninitialized
--Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type \
--Wold-style-declaration -Wold-style-definition"
+-Wmissing-declarations
+-Wmissing-prototypes
+-Wdeclaration-after-statement -Wmissing-parameter-type
+-Wpointer-sign
+-Wold-style-declaration -Wold-style-definition
+"
 
 # Enable -Wno-format by default when using gcc on mingw since many
 # GCC versions complain about %I64.