[binutils-gdb] sim: frv: fix some printf type mismatch warnings

Michael Frysinger vapier@sourceware.org
Mon Jun 28 03:33:34 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2b83b95803d745d0a57ae7331a285aa692c6e425

commit 2b83b95803d745d0a57ae7331a285aa692c6e425
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Sun Jun 27 00:02:11 2021 -0400

    sim: frv: fix some printf type mismatch warnings
    
    The %p usage was a real bug that would probably cause a crash.

Diff:
---
 sim/frv/ChangeLog | 5 +++++
 sim/frv/profile.c | 2 +-
 sim/frv/sim-if.c  | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/sim/frv/ChangeLog b/sim/frv/ChangeLog
index 0877169b7f0..cb4e2cfeaa1 100644
--- a/sim/frv/ChangeLog
+++ b/sim/frv/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-27  Mike Frysinger  <vapier@gentoo.org>
+
+	* profile.c (wait_for_flush): Change %p to %x.
+	* sim-if.c (sim_open): Change %lx to %x.
+
 2021-06-27  Mike Frysinger  <vapier@gentoo.org>
 
 	* traps.c (frv_break): Delete pc and pass down NULL_CIA.
diff --git a/sim/frv/profile.c b/sim/frv/profile.c
index 94212bfa0f3..89332e58040 100644
--- a/sim/frv/profile.c
+++ b/sim/frv/profile.c
@@ -901,7 +901,7 @@ wait_for_flush (SIM_CPU *cpu)
     }
   if (TRACE_INSN_P (cpu) && wait)
     {
-      sprintf (hazard_name, "Data cache flush address %p:", address);
+      sprintf (hazard_name, "Data cache flush address %x:", address);
       frv_model_trace_wait_cycles (cpu, wait, hazard_name);
     }
 }
diff --git a/sim/frv/sim-if.c b/sim/frv/sim-if.c
index 758e17a3fc5..3dd76ad7c9c 100644
--- a/sim/frv/sim-if.c
+++ b/sim/frv/sim-if.c
@@ -86,7 +86,7 @@ sim_open (SIM_OPEN_KIND kind, host_callback *callback, bfd *abfd,
   /* Allocate core managed memory if none specified by user.
      Use address 4 here in case the user wanted address 0 unmapped.  */
   if (sim_core_read_buffer (sd, NULL, read_map, &c, 4, 1) == 0)
-    sim_do_commandf (sd, "memory region 0,0x%lx", FRV_DEFAULT_MEM_SIZE);
+    sim_do_commandf (sd, "memory region 0,0x%x", FRV_DEFAULT_MEM_SIZE);
 
   /* check for/establish the reference program image */
   if (sim_analyze_program (sd,


More information about the Gdb-cvs mailing list