[binutils-gdb] gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main

Simon Marchi simark@sourceware.org
Mon Jun 7 16:53:54 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cfc75767cc276fb9e10c8239bb23c800a7f07e47

commit cfc75767cc276fb9e10c8239bb23c800a7f07e47
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Mon Jun 7 12:51:34 2021 -0400

    gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main
    
    While doing some changes, I managed to break this test in a way that
    running to main didn't work.  However, it didn't produce any FAIL.  I
    noticed because I diff'ed the results and saw some PASSes unexpectedly
    disappear, but that's a bit fragile.  Add a fail in case this test fails
    to run to main.  Ideally, I think that runto_main should by default
    produce a FAIL when it fails (the opposite of the existing logic), but
    that's a project of its own, so just fix this test for the moment.
    
    gdb/testsuite/ChangeLog:
    
            * gdb.base/continue-all-already-running.exp: Call fail if can't
            run to main.
    
    Change-Id: I84b816a126c92ac579ed5ebbe39b017bd5cb7096

Diff:
---
 gdb/testsuite/ChangeLog                                 | 5 +++++
 gdb/testsuite/gdb.base/continue-all-already-running.exp | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fd78401774b..45040960d0f 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-07  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* gdb.base/continue-all-already-running.exp: Call fail if can't
+	run to main.
+
 2021-06-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	PR gdb/27847
diff --git a/gdb/testsuite/gdb.base/continue-all-already-running.exp b/gdb/testsuite/gdb.base/continue-all-already-running.exp
index 23cd9920bc7..de84897c766 100644
--- a/gdb/testsuite/gdb.base/continue-all-already-running.exp
+++ b/gdb/testsuite/gdb.base/continue-all-already-running.exp
@@ -26,6 +26,7 @@ save_vars { GDBFLAGS } {
 }
 
 if ![runto_main] {
+    fail "can't run to main"
     return
 }


More information about the Gdb-cvs mailing list