[binutils-gdb] gdb: symmisc.c: remove std_{in,out,err}

Simon Marchi simark@sourceware.org
Fri Feb 5 18:16:47 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0110ec824ef40f3f08b8670bdfa2160d157e2000

commit 0110ec824ef40f3f08b8670bdfa2160d157e2000
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Feb 5 13:06:33 2021 -0500

    gdb: symmisc.c: remove std_{in,out,err}
    
    These are likely not very useful, remove them.
    
    gdb/ChangeLog:
    
            * symmisc.c (std_in, std_out, std_err): Remove.
            (_initialize_symmisc): Don't set std_in, std_out and std_err.
    
    Change-Id: I140bfffd7fb655d39c32333bb53924b91b1eb13c

Diff:
---
 gdb/ChangeLog |  5 +++++
 gdb/symmisc.c | 14 --------------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1f5840e5701..78cd0590e51 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-02-05  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* symmisc.c (std_in, std_out, std_err): Remove.
+	(_initialize_symmisc): Don't set std_in, std_out and std_err.
+
 2021-02-05  Tom de Vries  <tdevries@suse.de>
 
 	PR breakpoints/27330
diff --git a/gdb/symmisc.c b/gdb/symmisc.c
index a8f8856f721..fe353bc0ff7 100644
--- a/gdb/symmisc.c
+++ b/gdb/symmisc.c
@@ -41,16 +41,6 @@
 #include "psymtab.h"
 #include "psympriv.h"
 
-/* Unfortunately for debugging, stderr is usually a macro.  This is painful
-   when calling functions that take FILE *'s from the debugger.
-   So we make a variable which has the same value and which is accessible when
-   debugging GDB with itself.  Because stdin et al need not be constants,
-   we initialize them in the _initialize_symmisc function at the bottom
-   of the file.  */
-static FILE *std_in;
-static FILE *std_out;
-static FILE *std_err;
-
 /* Prototypes for local functions */
 
 static int block_depth (const struct block *);
@@ -1102,10 +1092,6 @@ void _initialize_symmisc ();
 void
 _initialize_symmisc ()
 {
-  std_in = stdin;
-  std_out = stdout;
-  std_err = stderr;
-
   add_cmd ("symbols", class_maintenance, maintenance_print_symbols, _("\
 Print dump of current symbol definitions.\n\
 Usage: mt print symbols [-pc ADDRESS] [--] [OUTFILE]\n\


More information about the Gdb-cvs mailing list