[binutils-gdb] gdb: Use correct feature in tdesc-regs for ARC

Shahab Vahedi shahab@sourceware.org
Thu Feb 4 19:33:02 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3eccb1c8bfd1f119bbc55bf2821d0e4d76116b67

commit 3eccb1c8bfd1f119bbc55bf2821d0e4d76116b67
Author: Shahab Vahedi <shahab@synopsys.com>
Date:   Tue Dec 10 16:25:08 2019 +0100

    gdb: Use correct feature in tdesc-regs for ARC
    
    tdesc-regs.exp test fails for ARC because the test is not
    using the correct XML files as target description.  With
    this change, the correct directory and files are used.
    
    v2 (after Andrew's remark [1]):
    - Update the feature file names again.  Test results now:
    
      Test run by shahab on Tue Jan 26 11:31:16 2021
      Target is arc-default-elf32
      Host   is x86_64-unknown-linux-gnu
    
                      === gdb tests ===
    
      Schedule of variations:
          arc-nsim
    
      Running target arc-nsim
      Running /src/gdb/testsuite/gdb.xml/tdesc-regs.exp ...
      PASS: gdb.xml/tdesc-regs.exp: set tdesc file single-reg.xml
      PASS: gdb.xml/tdesc-regs.exp: cd to directory holding xml
      PASS: gdb.xml/tdesc-regs.exp: set tdesc filename test-extra-regs.xml...
      PASS: gdb.xml/tdesc-regs.exp: ptype $extrareg
      PASS: gdb.xml/tdesc-regs.exp: ptype $uintreg
      PASS: gdb.xml/tdesc-regs.exp: ptype $vecreg
      PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg
      PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg.v4
      PASS: gdb.xml/tdesc-regs.exp: ptype $structreg
      PASS: gdb.xml/tdesc-regs.exp: ptype $structreg.v4
      PASS: gdb.xml/tdesc-regs.exp: ptype $bitfields
      PASS: gdb.xml/tdesc-regs.exp: ptype $flags
      PASS: gdb.xml/tdesc-regs.exp: ptype $mixed_flags
      PASS: gdb.xml/tdesc-regs.exp: maintenance print reggroups
      PASS: gdb.xml/tdesc-regs.exp: core-only.xml: set tdesc filename...
      PASS: gdb.xml/tdesc-regs.exp: core-only.xml: ptype $extrareg
    
                    === gdb Summary ===
    
      # of expected passes          16
    
    [1]
    https://sourceware.org/pipermail/gdb-patches/2021-January/175465.html
    
    gdb/testsuite/ChangeLog:
    
            * gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.

Diff:
---
 gdb/testsuite/ChangeLog              | 4 ++++
 gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 62c06d0f52c..a449de04587 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-02-04  Shahab Vahedi  <shahab@synopsys.com>
+
+	* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
+
 2021-02-03  Pedro Alves  <pedro@palves.net>
 
 	* gdb.threads/detach-step-over.c: New file.
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 1ee6ae1bff3..7402ba8d952 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -32,7 +32,8 @@ switch -glob -- [istarget] {
     }
     "arc*-*-*" {
 	set architecture "arc:ARCv2"
-	set core-regs {arc-v2.xml}
+	set regdir "arc/"
+	set core-regs {v2-core.xml v2-aux.xml}
     }
     "arm*-*-*" {
 	set regdir "arm/"


More information about the Gdb-cvs mailing list