[binutils-gdb] Make get_image_name static

Tom Tromey tromey@sourceware.org
Fri Apr 30 16:23:18 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1bee48c7ad5b75896ef8d84fedc774e181fb09a7

commit 1bee48c7ad5b75896ef8d84fedc774e181fb09a7
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Apr 30 10:22:23 2021 -0600

    Make get_image_name static
    
    The only callers of get_image_name are nat/windows-nat.c, so make it
    static.
    
    gdb/ChangeLog
    2021-04-30  Tom Tromey  <tromey@adacore.com>
    
            * nat/windows-nat.h (get_image_name): Don't declare.
            * nat/windows-nat.c (get_image_name): Now static.

Diff:
---
 gdb/ChangeLog         | 5 +++++
 gdb/nat/windows-nat.c | 8 +++++++-
 gdb/nat/windows-nat.h | 7 -------
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4bb6ef832d9..16c0ef746d9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-04-30  Tom Tromey  <tromey@adacore.com>
+
+	* nat/windows-nat.h (get_image_name): Don't declare.
+	* nat/windows-nat.c (get_image_name): Now static.
+
 2021-04-30  Tom Tromey  <tromey@adacore.com>
 
 	* windows-nat.c (windows_nat::handle_load_dll): Update.
diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c
index 377810c9f0e..0bb87ec0674 100644
--- a/gdb/nat/windows-nat.c
+++ b/gdb/nat/windows-nat.c
@@ -120,7 +120,13 @@ windows_thread_info::resume ()
   suspended = 0;
 }
 
-const char *
+/* Return the name of the DLL referenced by H at ADDRESS.  UNICODE
+   determines what sort of string is read from the inferior.  Returns
+   the name of the DLL, or NULL on error.  If a name is returned, it
+   is stored in a static buffer which is valid until the next call to
+   get_image_name.  */
+
+static const char *
 get_image_name (HANDLE h, void *address, int unicode)
 {
 #ifdef __CYGWIN__
diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h
index 821866bc63f..d8c5cfb2bd5 100644
--- a/gdb/nat/windows-nat.h
+++ b/gdb/nat/windows-nat.h
@@ -220,13 +220,6 @@ extern bool wow64_process;
 extern bool ignore_first_breakpoint;
 #endif
 
-/* Return the name of the DLL referenced by H at ADDRESS.  UNICODE
-   determines what sort of string is read from the inferior.  Returns
-   the name of the DLL, or NULL on error.  If a name is returned, it
-   is stored in a static buffer which is valid until the next call to
-   get_image_name.  */
-extern const char *get_image_name (HANDLE h, void *address, int unicode);
-
 typedef enum
 {
   HANDLE_EXCEPTION_UNHANDLED = 0,


More information about the Gdb-cvs mailing list