[binutils-gdb] sim: add some stdlib.h includes
Simon Marchi
simark@sourceware.org
Mon Jan 20 00:48:00 GMT 2020
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b760fb3a1cd35fda01843ee7cdb3e420f07d27b9
commit b760fb3a1cd35fda01843ee7cdb3e420f07d27b9
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sun Jan 19 19:47:17 2020 -0500
sim: add some stdlib.h includes
When trying to compile GDB with --target=avr, with gcc 9.2.0, I am
getting a bunch of:
/home/simark/src/binutils-gdb/sim/avr/../common/nrun.c:94:7: error: implicit declaration of function ââ¬ÃÂabortâ≢ [-Werror=implicit-function-declaration]
94 | abort ();
| ^~~~~
/home/simark/src/binutils-gdb/sim/avr/../common/nrun.c:94:7: error: incompatible implicit declaration of built-in function ââ¬ÃÂabortâ≢ [-Werror]
/home/simark/src/binutils-gdb/sim/avr/../common/nrun.c:94:7: note: include ââ¬ÃÂ<stdlib.h>â≢ or provide a declaration of ââ¬ÃÂabortâ≢
I did what the compiler told me and added the relevant includes in the
problematic files.
sim/common/ChangeLog:
* nrun.c: Include stdlib.h.
* sim-core.c: Likewise.
* sim-engine.c: Likewise.
* sim-io.c: Likewise.
* sim-module.c: Likewise.
* sim-reason.c: Likewise.
Diff:
---
sim/common/ChangeLog | 9 +++++++++
sim/common/nrun.c | 1 +
sim/common/sim-core.c | 2 ++
sim/common/sim-engine.c | 5 +++--
sim/common/sim-io.c | 2 ++
sim/common/sim-module.c | 2 ++
sim/common/sim-reason.c | 2 ++
7 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index 6610c7b..a1ac3f1 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,3 +1,12 @@
+2020-01-19 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * nrun.c: Include stdlib.h.
+ * sim-core.c: Likewise.
+ * sim-engine.c: Likewise.
+ * sim-io.c: Likewise.
+ * sim-module.c: Likewise.
+ * sim-reason.c: Likewise.
+
2019-12-19 Tom Tromey <tromey@adacore.com>
PR build/24572:
diff --git a/sim/common/nrun.c b/sim/common/nrun.c
index abd821a..cbf7b5e 100644
--- a/sim/common/nrun.c
+++ b/sim/common/nrun.c
@@ -20,6 +20,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#endif
#include <signal.h>
+#include <stdlib.h>
/* For strsignal. */
#ifdef HAVE_STRING_H
diff --git a/sim/common/sim-core.c b/sim/common/sim-core.c
index ce26dd3..df46def 100644
--- a/sim/common/sim-core.c
+++ b/sim/common/sim-core.c
@@ -30,6 +30,8 @@
#include "sim-hw.h"
#endif
+#include <stdlib.h>
+
/* "core" module install handler.
This is called via sim_module_install to install the "core"
diff --git a/sim/common/sim-engine.c b/sim/common/sim-engine.c
index f9961f8..d6e091d 100644
--- a/sim/common/sim-engine.c
+++ b/sim/common/sim-engine.c
@@ -17,11 +17,12 @@ GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-#include <stdio.h>
-
#include "sim-main.h"
#include "sim-assert.h"
+#include <stdio.h>
+#include <stdlib.h>
+
/* Get the run state.
REASON/SIGRC are the values returned by sim_stop_reason.
??? Should each cpu have its own copy? */
diff --git a/sim/common/sim-io.c b/sim/common/sim-io.c
index 05ba018..989f9cf 100644
--- a/sim/common/sim-io.c
+++ b/sim/common/sim-io.c
@@ -33,6 +33,8 @@
#include <unistd.h>
#endif
+#include <stdlib.h>
+
/* Define the rate at which the simulator should poll the host
for a quit. */
#ifndef POLL_QUIT_INTERVAL
diff --git a/sim/common/sim-module.c b/sim/common/sim-module.c
index 2ea54c1..1b103b7 100644
--- a/sim/common/sim-module.c
+++ b/sim/common/sim-module.c
@@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "libiberty.h"
+#include <stdlib.h>
+
/* List of all modules. */
static MODULE_INSTALL_FN * const modules[] = {
standard_install,
diff --git a/sim/common/sim-reason.c b/sim/common/sim-reason.c
index d74496a..83b2424 100644
--- a/sim/common/sim-reason.c
+++ b/sim/common/sim-reason.c
@@ -20,6 +20,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "sim-main.h"
#include "sim-assert.h"
+#include <stdlib.h>
+
/* Generic implementation of sim_stop_reason */
void
More information about the Gdb-cvs
mailing list