[binutils-gdb] gdbserver: make aarch64_write_goto_address static

Simon Marchi simark@sourceware.org
Sun Jan 12 16:07:00 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bb1183e25ae74ba21500fb4e39bc1ca9822e3086

commit bb1183e25ae74ba21500fb4e39bc1ca9822e3086
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Sun Jan 12 11:06:23 2020 -0500

    gdbserver: make aarch64_write_goto_address static
    
    This function is only used in this file, so make it static.  It fixes
    this error, when building with -Wmissing-declarations:
    
      CXX    linux-aarch64-low.o
    /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:2642:1: error: no previous declaration for 'void aarch64_write_goto_address(CORE_ADDR, CORE_ADDR, int)' [-Werror=missing-declarations]
     aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
    
    gdb/gdbserver/ChangeLog:
    
    	* linux-aarch64-low.c (aarch64_write_goto_address): Make static.

Diff:
---
 gdb/gdbserver/ChangeLog           | 4 ++++
 gdb/gdbserver/linux-aarch64-low.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 40a765a..83be63c 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
 
+	* linux-aarch64-low.c (aarch64_write_goto_address): Make static.
+
+2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
+
 	* linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h.
 	* linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h.
 
diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index c58347d..961fd5b 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -2638,7 +2638,7 @@ aarch64_emit_goto (int *offset_p, int *size_p)
 
 /* Implementation of emit_ops method "write_goto_address".  */
 
-void
+static void
 aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size)
 {
   uint32_t insn;



More information about the Gdb-cvs mailing list