[binutils-gdb] gdb/testsuite/tui: Always dump_screen when asked

[Andrew Burgess]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=63ffd7c9131c0e9723016d33cf8d435cc508d02b

commit 63ffd7c9131c0e9723016d33cf8d435cc508d02b
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Tue Jan 7 00:26:22 2020 +0000

    gdb/testsuite/tui: Always dump_screen when asked
    
    The Term::dump_screen routine currently dumps the screen using calls
    to 'verbose', this means it will only dump the screen when the
    testsuite is running in verbose mode.
    
    However, the Term::dump_screen is most often called when a test fails,
    in this case I think it is useful to have the screen dumped even when
    we're not in verbose mode.
    
    This commit changes the calls to 'verbose' to be 'verbose -log' so we
    always get the screen dump.
    
    gdb/testsuite/ChangeLog:
    
    	* lib/tuiterm.exp (Term::dump_screen): Always dump the screen when
    	called.
    
    Change-Id: I5f0a7f5ac2ece04d6fe6e9c5a28ea2a0dda38955

Diff:
---
 gdb/testsuite/ChangeLog       | 5 +++++
 gdb/testsuite/lib/tuiterm.exp | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index cecd384..6ca5aef 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 
+	* lib/tuiterm.exp (Term::dump_screen): Always dump the screen when
+	called.
+
+2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
+
 	* gdb.base/skip.exp: Fix race condition in test.
 
 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp
index 6f3d41f..36e034a 100644
--- a/gdb/testsuite/lib/tuiterm.exp
+++ b/gdb/testsuite/lib/tuiterm.exp
@@ -595,10 +595,10 @@ namespace eval Term {
     proc dump_screen {} {
 	variable _rows
 	variable _cols
-	verbose "Screen Dump ($_cols x $_rows):"
+	verbose -log "Screen Dump ($_cols x $_rows):"
 	for {set y 0} {$y < $_rows} {incr y} {
 	    set fmt [format %5d $y]
-	    verbose "$fmt [get_line $y]"
+	    verbose -log "$fmt [get_line $y]"
 	}
     }