[binutils-gdb] gdb: delete unused function print_char_chars

Andrew Burgess aburgess@sourceware.org
Wed Dec 23 20:54:37 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=016382f8a43a59eca49f68c7d8b8058f64eaf40f

commit 016382f8a43a59eca49f68c7d8b8058f64eaf40f
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Mon Oct 19 17:44:15 2020 +0100

    gdb: delete unused function print_char_chars
    
    Spotted that print_char_chars appears to be unused, delete it.  There
    should be no user visible changes after this commit.
    
    gdb/ChangeLog:
    
            * valprint.c (print_char_chars): Delete definition.
            * valprint.h (print_char_chars): Delete declaration.

Diff:
---
 gdb/ChangeLog  |  5 +++++
 gdb/valprint.c | 37 -------------------------------------
 gdb/valprint.h |  3 ---
 3 files changed, 5 insertions(+), 40 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0f702d997bb..6788fc76ad5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-12-23  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* valprint.c (print_char_chars): Delete definition.
+	* valprint.h (print_char_chars): Delete declaration.
+
 2020-12-23  Samuel Thibault  <samuel.thibault@ens-lyon.org>
 
 	* i386-gnu-tdep.c (I386_GNU_UCONTEXT_T_THREAD_STATE_OFFSET): New
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 50278ac3093..baf8f765465 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -1827,43 +1827,6 @@ print_hex_chars (struct ui_file *stream, const gdb_byte *valaddr,
     }
 }
 
-/* VALADDR points to a char integer of LEN bytes.
-   Print it out in appropriate language form on stream.
-   Omit any leading zero chars.  */
-
-void
-print_char_chars (struct ui_file *stream, struct type *type,
-		  const gdb_byte *valaddr,
-		  unsigned len, enum bfd_endian byte_order)
-{
-  const gdb_byte *p;
-
-  if (byte_order == BFD_ENDIAN_BIG)
-    {
-      p = valaddr;
-      while (p < valaddr + len - 1 && *p == 0)
-	++p;
-
-      while (p < valaddr + len)
-	{
-	  LA_EMIT_CHAR (*p, type, stream, '\'');
-	  ++p;
-	}
-    }
-  else
-    {
-      p = valaddr + len - 1;
-      while (p > valaddr && *p == 0)
-	--p;
-
-      while (p >= valaddr)
-	{
-	  LA_EMIT_CHAR (*p, type, stream, '\'');
-	  --p;
-	}
-    }
-}
-
 /* Print function pointer with inferior address ADDRESS onto stdio
    stream STREAM.  */
 
diff --git a/gdb/valprint.h b/gdb/valprint.h
index ef9ebfa84f0..47f6ed009b9 100644
--- a/gdb/valprint.h
+++ b/gdb/valprint.h
@@ -157,9 +157,6 @@ extern void print_decimal_chars (struct ui_file *, const gdb_byte *,
 extern void print_hex_chars (struct ui_file *, const gdb_byte *,
 			     unsigned int, enum bfd_endian, bool);
 
-extern void print_char_chars (struct ui_file *, struct type *,
-			      const gdb_byte *, unsigned int, enum bfd_endian);
-
 extern void print_function_pointer_address (const struct value_print_options *options,
 					    struct gdbarch *gdbarch,
 					    CORE_ADDR address,


More information about the Gdb-cvs mailing list