[binutils-gdb] Remove UNDEFINED_ITEM define from TUI

Tom Tromey tromey@sourceware.org
Wed Jul 17 18:38:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d1b6f1e5ebdd755274a77a31c4afa48969b73bee

commit d1b6f1e5ebdd755274a77a31c4afa48969b73bee
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Jun 28 22:51:20 2019 -0600

    Remove UNDEFINED_ITEM define from TUI
    
    The TUI defined UNDEFINED_ITEM, but only used it in a single spot.  I
    think this isn't very useful, so this removes the define.
    
    gdb/ChangeLog
    2019-07-17  Tom Tromey  <tom@tromey.com>
    
    	* tui/tui-data.h (UNDEFINED_ITEM): Remove define.
    	(struct tui_data_item_window): Update.

Diff:
---
 gdb/ChangeLog      | 5 +++++
 gdb/tui/tui-data.h | 3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b0a4fd6..ee17d50 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-07-17  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-data.h (UNDEFINED_ITEM): Remove define.
+	(struct tui_data_item_window): Update.
+
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 	(DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 	defines.
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index de52215..125b4ae 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -104,7 +104,6 @@ enum tui_box
 #define DISASSEM_NAME           "asm"
 #define HILITE                  TRUE
 #define NO_HILITE               FALSE
-#define UNDEFINED_ITEM          -1
 #define MIN_WIN_HEIGHT          3
 #define MIN_CMD_WIN_HEIGHT      3
 
@@ -263,7 +262,7 @@ struct tui_data_item_window : public tui_gen_win_info
 
   const char *name = nullptr;
   /* The register number, or data display number.  */
-  int item_no = UNDEFINED_ITEM;
+  int item_no = -1;
   void *value = nullptr;
   bool highlight = false;
   char *content = nullptr;



More information about the Gdb-cvs mailing list