[binutils-gdb] Don't include readline headers from tracepoint.c
Tom Tromey
tromey@sourceware.org
Tue Aug 13 18:39:00 GMT 2019
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=29c9291108487e1dd9bc5677dafee58ea2068f77
commit 29c9291108487e1dd9bc5677dafee58ea2068f77
Author: Tom Tromey <tromey@adacore.com>
Date: Mon Aug 12 12:06:20 2019 -0600
Don't include readline headers from tracepoint.c
I was curious why updating readline caused so much to be to rebuilt,
so I look at all the uses of the readline headers. Most are included
for valid reasons (either readline directory or for tilde_expand); but
the includes in tracepoint.c didn't seem to be used.
This patch removes them. Tested by rebuilding.
gdb/ChangeLog
2019-08-13 Tom Tromey <tromey@adacore.com>
* tracepoint.c: Don't include readline.h or history.h.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/tracepoint.c | 7 -------
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 12998aa..6c4208f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-13 Tom Tromey <tromey@adacore.com>
+
+ * tracepoint.c: Don't include readline.h or history.h.
+
2019-08-12 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index ed1d75e..2d5b9c7 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -58,13 +58,6 @@
#include "location.h"
#include <algorithm>
-/* readline include files */
-#include "readline/readline.h"
-#include "readline/history.h"
-
-/* readline defines this. */
-#undef savestring
-
#include <unistd.h>
/* Maximum length of an agent aexpression.
More information about the Gdb-cvs
mailing list