[binutils-gdb] Fix Rust testing

Tom Tromey tromey@sourceware.org
Wed Apr 24 19:44:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1670072efb31e82d52d408940062860e2835d79c

commit 1670072efb31e82d52d408940062860e2835d79c
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Apr 24 13:43:27 2019 -0600

    Fix Rust testing
    
    This changes the gdb test suite to omit -fno-stack-protector when
    compiling Rust code.  This makes Rust testing work again.
    
    I think I saw this patch somewhere already, but I couldn't find it
    again just now, so I'm checking this version in.
    
    gdb/testsuite/ChangeLog
    2019-04-24  Tom Tromey  <tromey@adacore.com>
    
    	* lib/gdb.exp (gdb_compile): Don't add -fno-stack-protector for
    	Rust.

Diff:
---
 gdb/testsuite/ChangeLog   | 5 +++++
 gdb/testsuite/lib/gdb.exp | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 23ff7bc..580c15e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2019-04-24  Tom Tromey  <tromey@adacore.com>
 
+	* lib/gdb.exp (gdb_compile): Don't add -fno-stack-protector for
+	Rust.
+
+2019-04-24  Tom Tromey  <tromey@adacore.com>
+
 	* gdb.arch/amd64-eval.exp: Test bitfield return.
 	* gdb.arch/amd64-eval.cc (struct Bitfields): New.
 	(class Foo) <return_bitfields>: New method.
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 1176fdd..eaf7fc4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3564,7 +3564,8 @@ proc gdb_compile {source dest type options} {
     if { $getting_compiler_info == 0
 	 && [test_compiler_info {gcc-*-*}]
 	 && !([test_compiler_info {gcc-[0-3]-*}]
-	      || [test_compiler_info {gcc-4-0-*}]) } {
+	      || [test_compiler_info {gcc-4-0-*}])
+	 && [lsearch -exact $options rust] == -1} {
         # Put it at the front to not override any user-provided value.
         lappend new_options "early_flags=-fno-stack-protector"
     }



More information about the Gdb-cvs mailing list