[binutils-gdb] [gdb/testsuite] Fix capitalized test names

Tom de Vries vries@sourceware.org
Thu Oct 18 13:07:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=812cd6eb0502fa87b6e1d3e751ac2e9239680cf4

commit 812cd6eb0502fa87b6e1d3e751ac2e9239680cf4
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Oct 18 13:23:08 2018 +0200

    [gdb/testsuite] Fix capitalized test names
    
    At https://sourceware.org/gdb/wiki/GDBTestcaseCookbook\
      #Follow_the_test_name_convention we find:
    ..
    Test names should start with a lower case and don't need to end with a period
    (they are not sentences).
    ...
    
    Fix some capitalized test names.
    
    Tested on x86_64-linux.
    
    2018-10-18  Tom de Vries  <tdevries@suse.de>
    
    	* gdb.ada/bp_inlined_func.exp: Fix capitalized test name.
    	* gdb.ada/excep_handle.exp: Same.
    	* gdb.ada/mi_string_access.exp: Same.
    	* gdb.ada/mi_var_union.exp: Same.
    	* gdb.arch/arc-analyze-prologue.exp: Same.
    	* gdb.arch/arc-decode-insn.exp: Same.
    	* gdb.base/readnever.exp: Same.
    	* gdb.fortran/printing-types.exp: Same.
    	* gdb.guile/scm-lazy-string.exp: Same.

Diff:
---
 gdb/testsuite/ChangeLog                         | 12 ++++++++++++
 gdb/testsuite/gdb.ada/bp_inlined_func.exp       |  2 +-
 gdb/testsuite/gdb.ada/excep_handle.exp          |  2 +-
 gdb/testsuite/gdb.ada/mi_string_access.exp      |  2 +-
 gdb/testsuite/gdb.ada/mi_var_union.exp          |  2 +-
 gdb/testsuite/gdb.arch/arc-analyze-prologue.exp |  2 +-
 gdb/testsuite/gdb.arch/arc-decode-insn.exp      |  2 +-
 gdb/testsuite/gdb.base/readnever.exp            |  2 +-
 gdb/testsuite/gdb.fortran/printing-types.exp    |  2 +-
 gdb/testsuite/gdb.guile/scm-lazy-string.exp     |  2 +-
 10 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 90ce8af..8fa224a 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,15 @@
+2018-10-18  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.ada/bp_inlined_func.exp: Fix capitalized test name.
+	* gdb.ada/excep_handle.exp: Same.
+	* gdb.ada/mi_string_access.exp: Same.
+	* gdb.ada/mi_var_union.exp: Same.
+	* gdb.arch/arc-analyze-prologue.exp: Same.
+	* gdb.arch/arc-decode-insn.exp: Same.
+	* gdb.base/readnever.exp: Same.
+	* gdb.fortran/printing-types.exp: Same.
+	* gdb.guile/scm-lazy-string.exp: Same.
+
 2018-10-16  Tom de Vries  <tdevries@suse.de>
 
 	PR gdb/23730
diff --git a/gdb/testsuite/gdb.ada/bp_inlined_func.exp b/gdb/testsuite/gdb.ada/bp_inlined_func.exp
index 2013e6b..f7aa1c3 100644
--- a/gdb/testsuite/gdb.ada/bp_inlined_func.exp
+++ b/gdb/testsuite/gdb.ada/bp_inlined_func.exp
@@ -24,7 +24,7 @@ if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" }
 clean_restart ${testfile}
 
 if ![runto_main] then {
-   fail "Cannot run to main, testcase aborted"
+   fail "cannot run to main, testcase aborted"
    return 0
 }
 
diff --git a/gdb/testsuite/gdb.ada/excep_handle.exp b/gdb/testsuite/gdb.ada/excep_handle.exp
index c693fd3..b7cd6dc 100644
--- a/gdb/testsuite/gdb.ada/excep_handle.exp
+++ b/gdb/testsuite/gdb.ada/excep_handle.exp
@@ -43,7 +43,7 @@ set catchpoint_storage_error_msg \
 ############################################
 
 if ![runto_main] then {
-   fail "Cannot run to main, testcase aborted"
+   fail "cannot run to main, testcase aborted"
    return 0
 }
 
diff --git a/gdb/testsuite/gdb.ada/mi_string_access.exp b/gdb/testsuite/gdb.ada/mi_string_access.exp
index 8ecf907..adae4ab 100644
--- a/gdb/testsuite/gdb.ada/mi_string_access.exp
+++ b/gdb/testsuite/gdb.ada/mi_string_access.exp
@@ -34,7 +34,7 @@ mi_gdb_reinitialize_dir $srcdir/$subdir
 mi_gdb_load ${binfile}
 
 if ![mi_run_to_main] then {
-   fail "Cannot run to main, testcase aborted"
+   fail "cannot run to main, testcase aborted"
    return 0
 }
 
diff --git a/gdb/testsuite/gdb.ada/mi_var_union.exp b/gdb/testsuite/gdb.ada/mi_var_union.exp
index 26a7ed0..51147a4 100644
--- a/gdb/testsuite/gdb.ada/mi_var_union.exp
+++ b/gdb/testsuite/gdb.ada/mi_var_union.exp
@@ -36,7 +36,7 @@ mi_gdb_reinitialize_dir $srcdir/$subdir
 mi_gdb_load ${binfile}
 
 if ![mi_run_to_main] then {
-   fail "Cannot run to main, testcase aborted"
+   fail "cannot run to main, testcase aborted"
    return 0
 }
 
diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
index d874515..6a4d60e 100644
--- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
+++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp
@@ -27,7 +27,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
 }
 
 if ![runto_main] {
-    fail "Can't run to main"
+    fail "can't run to main"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.arch/arc-decode-insn.exp b/gdb/testsuite/gdb.arch/arc-decode-insn.exp
index 7ee666b..a4cd7c7 100644
--- a/gdb/testsuite/gdb.arch/arc-decode-insn.exp
+++ b/gdb/testsuite/gdb.arch/arc-decode-insn.exp
@@ -43,7 +43,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
 }
 
 if ![runto_main] {
-    fail "Can't run to main"
+    fail "can't run to main"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.base/readnever.exp b/gdb/testsuite/gdb.base/readnever.exp
index 805ecd2..c712dae 100644
--- a/gdb/testsuite/gdb.base/readnever.exp
+++ b/gdb/testsuite/gdb.base/readnever.exp
@@ -16,7 +16,7 @@
 standard_testfile .c
 
 if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
-    untested "Couldn't compile ${srcfile}"
+    untested "couldn't compile ${srcfile}"
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.fortran/printing-types.exp b/gdb/testsuite/gdb.fortran/printing-types.exp
index 9237907..885bb64 100644
--- a/gdb/testsuite/gdb.fortran/printing-types.exp
+++ b/gdb/testsuite/gdb.fortran/printing-types.exp
@@ -22,7 +22,7 @@ if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug f90}]} {
 }
 
 if {![runto MAIN__]} then {
-    untested "Could not run to breakpoint MAIN__"
+    untested "could not run to breakpoint MAIN__"
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.guile/scm-lazy-string.exp b/gdb/testsuite/gdb.guile/scm-lazy-string.exp
index 52211b3..13cc885 100644
--- a/gdb/testsuite/gdb.guile/scm-lazy-string.exp
+++ b/gdb/testsuite/gdb.guile/scm-lazy-string.exp
@@ -33,7 +33,7 @@ if { [skip_guile_tests] } { continue }
 # The following tests require execution.
 
 if ![gdb_guile_runto_main] {
-    fail "Can't run to main"
+    fail "can't run to main"
     return
 }



More information about the Gdb-cvs mailing list