[binutils-gdb] Remove obsolete comments from field_fmt

Tom Tromey tromey@sourceware.org
Sun Nov 25 22:36:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b5b12e1dbe0f2739624f91621828df73ef55e900

commit b5b12e1dbe0f2739624f91621828df73ef55e900
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Nov 25 12:30:20 2018 -0700

    Remove obsolete comments from field_fmt
    
    This removes some comments that I believe were made obsolete by the
    recent change to cli_ui_out::do_field_fmt.  The comment in mi_ui_out
    probably was just copy/paste, because I think aligning never made
    sense in an MI context.
    
    gdb/ChangeLog
    2018-11-25  Tom Tromey  <tom@tromey.com>
    
    	* ui-out.c (ui_out::field_fmt): Remove comment.
    	* tui/tui-out.c (tui_ui_out::do_field_fmt): Remove comment.
    	* mi/mi-out.c (mi_ui_out::do_field_fmt): Remove comment.

Diff:
---
 gdb/ChangeLog     | 6 ++++++
 gdb/mi/mi-out.c   | 2 --
 gdb/tui/tui-out.c | 2 --
 gdb/ui-out.c      | 1 -
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2515a4d..12523ca 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-11-25  Tom Tromey  <tom@tromey.com>
+
+	* ui-out.c (ui_out::field_fmt): Remove comment.
+	* tui/tui-out.c (tui_ui_out::do_field_fmt): Remove comment.
+	* mi/mi-out.c (mi_ui_out::do_field_fmt): Remove comment.
+
 2018-11-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
 	* source.c (open_source_file): Leak fixed in '8e6a5953e1d Fix 4K
diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c
index ea39fe2..39b18b0 100644
--- a/gdb/mi/mi-out.c
+++ b/gdb/mi/mi-out.c
@@ -124,8 +124,6 @@ mi_ui_out::do_field_string (int fldno, int width, ui_align align,
   fprintf_unfiltered (stream, "\"");
 }
 
-/* This is the only field function that does not align.  */
-
 void
 mi_ui_out::do_field_fmt (int fldno, int width, ui_align align,
 			 const char *fldname, const char *format,
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 40f736f..6d4e236 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -71,8 +71,6 @@ tui_ui_out::do_field_string (int fldno, int width, ui_align align,
   cli_ui_out::do_field_string (fldno, width, align, fldname, string);
 }
 
-/* This is the only field function that does not align.  */
-
 void
 tui_ui_out::do_field_fmt (int fldno, int width, ui_align align,
 			  const char *fldname, const char *format,
diff --git a/gdb/ui-out.c b/gdb/ui-out.c
index ebe0285..3d74f78 100644
--- a/gdb/ui-out.c
+++ b/gdb/ui-out.c
@@ -523,7 +523,6 @@ ui_out::field_fmt (const char *fldname, const char *format, ...)
   int width;
   ui_align align;
 
-  /* Will not align, but has to call anyway.  */
   verify_field (&fldno, &width, &align);
 
   va_start (args, format);



More information about the Gdb-cvs mailing list