[binutils-gdb] Darwin: fix bad loop incrementation

Simon Marchi simark@sourceware.org
Thu Aug 23 15:17:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=12a0d0f66172b9504e29000fa4f4e5c34109d6db

commit 12a0d0f66172b9504e29000fa4f4e5c34109d6db
Author: Xavier Roirand <roirand@adacore.com>
Date:   Thu Aug 23 11:17:03 2018 -0400

    Darwin: fix bad loop incrementation
    
    When reading symbols from the vector of oso files on Mac OS X
    Darwin, a previous commit introduce a change in the loop and add
    an increment at each loop iteration whereas this incrementation is
    not needed since the increment or set of the loop control variable
    is already done in the loop.
    
    gdb/ChangeLog:
    
    	* machoread.c (macho_symfile_read_all_oso): Remove uneeded
    	incrementation.
    
    Change-Id: I3a5a6deb4e9d834ee7d4217a62d90c2ffb7241bc

Diff:
---
 gdb/ChangeLog   | 5 +++++
 gdb/machoread.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 61b4e29..cdc31f8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-23  Xavier Roirand  <roirand@adacore.com>
+
+	* machoread.c (macho_symfile_read_all_oso): Remove uneeded
+	incrementation.
+
 2018-08-22  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* solib-svr4.c (read_program_headers_from_bfd): Return
diff --git a/gdb/machoread.c b/gdb/machoread.c
index 0cbd209..3040fe7 100644
--- a/gdb/machoread.c
+++ b/gdb/machoread.c
@@ -615,7 +615,7 @@ macho_symfile_read_all_oso (std::vector<oso_el> *oso_vector_ptr,
   std::sort (oso_vector_ptr->begin (), oso_vector_ptr->end (),
 	     oso_el_compare_name);
 
-  for (ix = 0; ix < oso_vector_ptr->size (); ++ix)
+  for (ix = 0; ix < oso_vector_ptr->size ();)
     {
       int pfx_len;



More information about the Gdb-cvs mailing list