[binutils-gdb] Rename size in get_core_register_section

Alan Hayward alahay01@sourceware.org
Fri Aug 10 09:26:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dbd534fee4a3d6479e4a84f0cd79bd188d94f4d0

commit dbd534fee4a3d6479e4a84f0cd79bd188d94f4d0
Author: Alan Hayward <alan.hayward@arm.com>
Date:   Fri Aug 10 10:17:12 2018 +0100

    Rename size in get_core_register_section
    
    Make it clearer that the size field indicates the size of the section.
    
    gdb/
    
    	* corelow.c (core_target::get_core_register_section): Rename
    	min_size to section_min_size.

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/corelow.c | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 338813a..bc68519 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-10  Alan Hayward  <alan.hayward@arm.com>
+
+	* corelow.c (core_target::get_core_register_section): Rename
+	min_size to section_min_size.
+
 2018-08-09  Jim Wilson  <jimw@sifive.com>
 
 	* Makefile.in (ALL_TARGET_OBS): Add riscv-linux-tdep.c.
diff --git a/gdb/corelow.c b/gdb/corelow.c
index 059ce2f..d3336cf 100644
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -106,7 +106,7 @@ public:
   void get_core_register_section (struct regcache *regcache,
 				  const struct regset *regset,
 				  const char *name,
-				  int min_size,
+				  int section_min_size,
 				  int which,
 				  const char *human_name,
 				  bool required);
@@ -569,7 +569,7 @@ void
 core_target::get_core_register_section (struct regcache *regcache,
 					const struct regset *regset,
 					const char *name,
-					int min_size,
+					int section_min_size,
 					int which,
 					const char *human_name,
 					bool required)
@@ -592,13 +592,13 @@ core_target::get_core_register_section (struct regcache *regcache,
     }
 
   size = bfd_section_size (core_bfd, section);
-  if (size < min_size)
+  if (size < section_min_size)
     {
       warning (_("Section `%s' in core file too small."),
 	       section_name.c_str ());
       return;
     }
-  if (size != min_size && !variable_size_section)
+  if (size != section_min_size && !variable_size_section)
     {
       warning (_("Unexpected size of section `%s' in core file."),
 	       section_name.c_str ());



More information about the Gdb-cvs mailing list