[binutils-gdb] Use gdbpy_ref in gdbpy_inferiors

Tom Tromey tromey@sourceware.org
Wed Jan 11 05:19:00 GMT 2017


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f59fe7f8e3e55472e6fcfb06677ff4925dad1f64

commit f59fe7f8e3e55472e6fcfb06677ff4925dad1f64
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Nov 6 21:23:31 2016 -0700

    Use gdbpy_ref in gdbpy_inferiors
    
    This changes gdbpy_inferiors to use gdbpy_ref.
    
    2017-01-10  Tom Tromey  <tom@tromey.com>
    
    	* python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref.

Diff:
---
 gdb/ChangeLog            |  4 ++++
 gdb/python/py-inferior.c | 18 +++++-------------
 2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dc6ef9a..330718a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2017-01-10  Tom Tromey  <tom@tromey.com>
 
+	* python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref.
+
+2017-01-10  Tom Tromey  <tom@tromey.com>
+
 	* python/py-function.c (convert_values_to_python, fnpy_init): Use
 	gdbpy_ref.
 
diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c
index f5462a4..995a3df 100644
--- a/gdb/python/py-inferior.c
+++ b/gdb/python/py-inferior.c
@@ -477,22 +477,14 @@ build_inferior_list (struct inferior *inf, void *arg)
 PyObject *
 gdbpy_inferiors (PyObject *unused, PyObject *unused2)
 {
-  PyObject *list, *tuple;
-
-  list = PyList_New (0);
-  if (!list)
+  gdbpy_ref list (PyList_New (0));
+  if (list == NULL)
     return NULL;
 
-  if (iterate_over_inferiors (build_inferior_list, list))
-    {
-      Py_DECREF (list);
-      return NULL;
-    }
-
-  tuple = PyList_AsTuple (list);
-  Py_DECREF (list);
+  if (iterate_over_inferiors (build_inferior_list, list.get ()))
+    return NULL;
 
-  return tuple;
+  return PyList_AsTuple (list.get ());
 }
 
 /* Membuf and memory manipulation.  */



More information about the Gdb-cvs mailing list