[binutils-gdb] btrace: fix non-stop check in to_wait

Markus Metzger mmetzger@sourceware.org
Fri Sep 18 12:34:00 GMT 2015


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5953356cc4f2bcbf76e2979c35283c11ce0ba992

commit 5953356cc4f2bcbf76e2979c35283c11ce0ba992
Author: Markus Metzger <markus.t.metzger@intel.com>
Date:   Tue Sep 8 16:13:47 2015 +0200

    btrace: fix non-stop check in to_wait
    
    The record btrace target stops other threads in non-stop mode after stepping
    the to-be-resumed thread.
    
    The check is done on the non_stop variable.  It should rather be done on
    target_is_non_stop_p ().  With all-stop on top of non-stop, infrun will
    take care of stopping other threads.
    
    gdb/
    	* record-btrace.c (record_btrace_wait): Replace non_stop check with
    	target_is_non_stop_p ().

Diff:
---
 gdb/ChangeLog       | 5 +++++
 gdb/record-btrace.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 81ba17a..d01455f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-09-18  Markus Metzger  <markus.t.metzger@intel.com>
+
+	* record-btrace.c (record_btrace_wait): Replace non_stop check with
+	target_is_non_stop_p ().
+
 2015-09-15  Pierre-Marie de Rodat  <derodat@adacore.com>
 
 	* ada-typeprint.c (print_array_type): Do not describe arrays as
diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 9e16ab4..2d8b20b 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -2104,7 +2104,7 @@ record_btrace_wait (struct target_ops *ops, ptid_t ptid,
   *status = record_btrace_step_thread (tp);
 
   /* Stop all other threads. */
-  if (!non_stop)
+  if (!target_is_non_stop_p ())
     ALL_NON_EXITED_THREADS (other)
       other->btrace.flags &= ~BTHR_MOVE;



More information about the Gdb-cvs mailing list