gdb and binutils branch master updated. 673dc4a0542b54d8da67e53eaaa94ace90085421

qiyao@sourceware.org qiyao@sourceware.org
Sat Oct 18 13:03:00 GMT 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  673dc4a0542b54d8da67e53eaaa94ace90085421 (commit)
      from  b53dfeb26ed06e97fff1e8f469e33637ebdf6624 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=673dc4a0542b54d8da67e53eaaa94ace90085421

commit 673dc4a0542b54d8da67e53eaaa94ace90085421
Author: Yao Qi <yao@codesourcery.com>
Date:   Tue Oct 14 15:40:15 2014 +0800

    Skip testing argv[0] on target argv[0] isn't available
    
    I see the following two fails on arm-none-eabi target, because argv[0]
    isn't available.
    
    print argv[0]^M
    $1 = 0x1f78 "/dev/null"^M
    (gdb) FAIL: gdb.base/argv0-symlink.exp: kept file symbolic link name
    
    print argv[0]^M
    $1 = 0x1f78 "/dev/null"^M
    (gdb) FAIL: gdb.base/argv0-symlink.exp: kept directory symbolic link name
    
    My first thought is to check [target_info exists noargs], and skip the
    test if it returns true.  However, noargs is set in gdbserver board
    files, so argv0-symlink.exp will be skipped on gdbserver board file.
    The change is too aggressive.
    
    When the program is running with gdbserver, argv[1] to argv[N] aren't
    available, but argv[0] is.  Fortunately, argv0-symlink.exp only
    requires argv[0].  argv0-symlink.exp can be run with gdbserver board
    file, as what we do now.
    
    What we need to check is whether argv[0] is available, so I add a new
    proc gdb_has_argv0 to do so by starting a program, and check
    argc/argv[0] to see whether argv[0] is available.
    
    Dan fixed the similar problem by checking noargs, which is too strong.
    https://sourceware.org/ml/gdb-patches/2010-02/msg00398.html as a
    result, the test is skipped on gdbserver.  This patch fixed it too.
    
    gdb/testsuite:
    
    2014-10-18  Yao Qi  <yao@codesourcery.com>
    
    	* gdb.base/argv0-symlink.exp: Check argv[0] value if
    	gdb_has_argv0 return true.
    	* gdb.guile/scm-value.exp (test_value_in_inferior): Don't
    	check [target_info exists noargs], check [gdb_has_argv0]
    	instead.
    	* gdb.python/py-value.exp (test_value_in_inferior): Likewise.
    	* lib/gdb.exp (gdb_has_argv0, gdb_has_argv0_1): New
    	procedures.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog                  |   11 +++
 gdb/testsuite/gdb.base/argv0-symlink.exp |   21 +++++--
 gdb/testsuite/gdb.guile/scm-value.exp    |   11 +++-
 gdb/testsuite/gdb.python/py-value.exp    |   10 +++-
 gdb/testsuite/lib/gdb.exp                |   98 ++++++++++++++++++++++++++++++
 5 files changed, 141 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
gdb and binutils



More information about the Gdb-cvs mailing list