[PATCH] Fix hpux10 string to real conversion defficiences

John David Anglin dave@hiauly1.hia.nrc.ca
Sat Mar 12 23:44:00 GMT 2011


> On 03/12/2011 02:04 PM, Jerry DeLisle wrote:
> > On 03/12/2011 08:01 AM, John David Anglin wrote:
> >>> I have reviewed the patch and FX'scomments. So far so good.
> >>>
> >>> I may have missed something in the thread, but are you planning
> >>> modifications to the functions that call convert_real to allow the nan
> >>> or inf strings to be passed to convert_real?
> >>>
> >>> The read_real function is already handling this for namelist and list
> >>> directed reads and I believe it is not needed by convert_real for those
> >>> functions.
> >>>
> >>> For formatted reads, read_f will error out on a nan or inf during the
> >>> read before calling convert_real.
> >>
> >> Here is take three. The configure checks are eliminated and a new
> >> function, convert_infnan, is added to convert INFs and NANs using
> >> builtins. It relies to some extent on the processing done by read_f,
> >> parse_real and read_real.
> >>
> >> Tested on hppa1.1-hp-hpux10.20, hppa2.0w-hp-hpux11.11, hppa64-hp-hpux11.11
> >> and i686-apple-darwin9 with no observed regressions.
> >>
> >> Ok?
> >
> > This is very intrusive this close to 4.6 release. With that said, I would like
> > to regression test a few more different platforms. I will start on mine here
> > shortly.
> >
> 
> Tested successful on x86-64 at -m64 and -m32.  I will say OK, but you may want 
> to check with release manager.  I have not heard if we are in Freeze yet.

I will hold to 4.7 as I don't think this is a regression, and there
is some risk a platform like vax will break since it doesn't have nans.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)



More information about the Gcc-patches mailing list