[PATCH 14/18] move TS_STATEMENT_LIST to be a substructure of TS_TYPED

Nathan Froyd froydnj@codesourcery.com
Fri Mar 11 12:23:00 GMT 2011


On Fri, Mar 11, 2011 at 01:01:37AM -0500, Jason Merrill wrote:
> On 03/10/2011 11:23 PM, Nathan Froyd wrote:
>> The new checks in add_stmt are
>> required to make sure that cur_stmt_list can always point at something
>> when calling append_to_statement_list_force.
>
> Why haven't we already pushed before we get to add_stmt?

That's a good question.  Possibly as a result of
append_to_statement_list_1 helpfully noticing that if we pass in a
pointer to NULL, it goes ahead and creates a list for us.  This works
nicely for the TREE_CHAIN-based stack, but not so nicely for the
VEC-based stack.

One wonders if the NULL checking in append_to_statement_list_1 could go
away...

-Nathan



More information about the Gcc-patches mailing list