libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS

[Rainer Orth]

Ian Lance Taylor <iant@google.com> writes:

> This patch to libgo only runs the networking dependent tests if
> GCCGO_RUN_ALL_TESTS is set in the environment.  This is PR 48017.  In
> that PR Rainer suggests having the tests drop back to UNSUPPORTED or
> UNRESOLVED if they fail to open a network connection.  That is tempting

My suggestion would have been to only change the test outcome for a `No
route to host' error (which would happen already for the DNS lookup).

> but I don't agree with it, because it means that the tests will never
> fail.  It might be better to have some way to test whether the network

Only if you change the test outcome for all errors, which obviously
isn't appropriate.

> is available and usable before running the tests.  However, that is in
> itself problematic, as people running all the gcc tests don't
> necessarily want their machine to start opening network connections.  So
> I think the compromise of requiring an environment variable works well.

Sort of works for me, but I fear that the tests will be only rarely be
run.  Perhaps the variable should be documented in the libgo/README*
files so at least libgo porters are aware of it.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University