PR 47793 - Support relative paths using -fprofile-generate

Martin Thuresson martint@google.com
Tue Mar 8 05:25:00 GMT 2011


On Mon, Mar 7, 2011 at 11:53 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Tue, Mar 1, 2011 at 17:07, Martin Thuresson <martint@google.com> wrote:
>> Ping.
>>
>> On Wed, Feb 23, 2011 at 3:37 PM, Martin Thuresson <martint@google.com> wrote:
>>> On Wed, Feb 23, 2011 at 10:21 AM, Martin Thuresson <martint@google.com> wrote:
>>>> Change 165596 and 168475 updated the code for handling gcda-paths. As
>>>> part of this change, relative paths stopped working.
>>>>
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47793
>>>>
>>>> This patch adds a guard so that "/" is not added when no prefix is
>>>> given.
>>>>
>>>> The added testcase uses the path "../gcc/". This puts the gcda in the
>>>> same directory, so that the cleanup-coverage-files will find them.
>>>>
>>>> I have tested the patch using "make bootstrap; make -k check" with
>>>> target x86_64-unknown-linux-gnu and saw no additional test failures.
>>>>
>>>> Let me know if there is any other testing I should do.
>>>
>>> ChangeLog
>>> gcc/
>>>
>>> 2011-02-23  Martin Thuresson  <martint@google.com>
>>>
>>>        PR gcov-profile/47793
>>>        * libgcov.c (gcov_exit): Support relative profile paths.
>>>
>>> gcc/testsuite/
>>>
>>> 2011-02-23  Martin Thuresson  <martint@google.com>
>>>
>>>        PR gcov-profile/47793
>>>        * gcc.dg/pr47793.c: New.
>
> Martin,
>
> Let's put it in google/main while the review is underway.  Is this a
> regression vs 4.5 or 4.4?  If so, it may be suitable for trunk (or the
> future release branch), but you will need an explicit approval from
> the release managers (CC'd).  If it's a new bug, then this should go
> in trunk after we re-enter stage 1.

I have not tested 4.5 yet, but looking at the SVN log, I believe
this was introduced 2010/10/17.

Martin



More information about the Gcc-patches mailing list