[4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

[Diego Novillo]

On Fri, Mar 4, 2011 at 20:07, Mike Stump <mikestump@comcast.net> wrote:

>> -     @echo "set GCC_UNDER_TEST \"$(GCC_FOR_TARGET)\"" >> ./tmp0
>
> ?  What's this?  GCC_UNDER_TEST is kinda important to testing.  I feel like I'm missing something trivial.

This is an artifact of the branch.  We used to force GCC_UNDER_TEST,
but we don't need to anymore.  It will become clear when I send the
patch against trunk.  I'm testing it now.  I will send it as soon as I
finish testing all the variants.

>
>> +     @echo "set TEST_SYSROOT \"$(SYSROOT_CFLAGS_FOR_TARGET)\"" >> ./tmp0
>
>> +    if [info exists TEST_SYSROOT] {
>> +     lappend options "additional_flags=$TEST_SYSROOT"
>> +    }
>
> So, this will cause a certain ordering on the command line.  If there is a testcase in the
> testsuite that tests that flag, this might cause the option under test to be overridden
> unless the TEST_SYSROOT option comes first on the command line.  You can glance
> at the .log file, and ensure that this option comes before the -O2 say, of the multilib
> options in a torture suite.

Thanks.  I see that I'm emitting it fairly late in the options.  I
will move it so this is added early in the command line.


Diego.