[4.7] Avoid global state in microblaze_handle_option

Michael Eager eager@eagerm.com
Fri Mar 4 15:27:00 GMT 2011


Joseph S. Myers wrote:
> This patch, for 4.7 and relative to a tree with
> <http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01709.html> applied,
> stops the Microblaze handle_option hook from using global state.
> Everything the hook does - warnings and setting a variable also set by
> another option - can be done using .opt features, so the hook is
> removed and replaced by use of those features.
> 
> Tested building cc1 and xgcc for cross to microblaze-elf.  Will commit
> to trunk for 4.7 in the absence of target maintainer objections.
> 
> 2011-03-03  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* config/microblaze/microblaze.c: Don't include opts.h.
> 	(microblaze_handle_option, TARGET_HANDLE_OPTION): Remove.
> 	* config/microblaze/microblaze.opt (mxl-stack-check): Use Warn.
> 	(mno-clearbss): Use Var and Warn.

OK to apply.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077



More information about the Gcc-patches mailing list