[PATCH] more enhancements to df on the mainline.

Richard Guenther richard.guenther@gmail.com
Wed Jan 18 20:11:00 GMT 2006


On 1/18/06, Daniel Berlin <dberlin@dberlin.org> wrote:
> > I have enclosed a new version of the patch, the first version had the frags
> > for the other two dependent patches in it.
> >
> > Sorry,
> >
> > Kenny
>
> Oh, I should point out why the hook takes a void * instead of a bitmap.
> Not everything that wants to include the target hooks includes something
> that declares or forward declares bitmap, however, forward declaring it
> simply caused errors.
>
> In the end, rather than add bitmap.h to the include list of everything on
> the planet, i void *'d the hook and just cast it where we actually are
> touching it.

You know this will require putting casts everywhere for the much beloved
compile-with-C++ project?  I'd rather figure out why forward declaring
bitmap didn't work.  I.e.

#ifndef GCC_BITMAP_H
#define HAVE_BITMAP_TYPEDEF
struct bitmap_p;
typedef struct bitmap_p *bitmap;
#endif

for the forward declaration should do the trick, no?  In bitmap.h guard
the typedef with HAVE_BITMAP_TYPEDEF.

Richard.



More information about the Gcc-patches mailing list