[PATCH] libcpp deferred pragma hack (PR c++/25294)

Mark Mitchell mark@codesourcery.com
Tue Jan 3 17:37:00 GMT 2006


Richard Henderson wrote:
> On Fri, Dec 30, 2005 at 11:03:45AM -0800, Mark Mitchell wrote:
> 
>>+      /* We smuggled the cpp_token->u.pragma value in an INTEGER_CST.  */
>>+      token->pragma_kind = TREE_INT_CST_LOW (token->value);
>>
>>I guess we have no convenient choice, but making value a union would be
>>nicer; I hate to add places where we wrap things in trees....
> 
> 
> Yeah, well, changing that means changing the interface to the
> lexer; at the moment we're provided simply with a tree*, and 
> not some wider structure.
> 
> If you really want me to clean this up, I'd prefer to do it as
> a separate patch, since it'll affect the C front end as well.

I don't think you should in any way feel obligated to untangle this, but
if you want to do it, that would be swell.  I was just griping.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713



More information about the Gcc-patches mailing list