Suggestions

[Jonathan Wakely]

On Fri, 6 Dec 2024, 13:23 Antoni Boucher, <bouanto@zoho.com> wrote:

> Hi.
> I started to use the forge to experiment.
> As part of my workflow, I use some labels to keep track of the status of
> my patches.
> This also helps David Malcolm who reviews my patches for libgccjit.
>
> To be able to use this workflow, I would need 2 changes:
>
>   * The ability for me and my reviewer to edit the labels on my pull
> requests.
>

I will add you to the GCC developer group, which I think would do it. But
if/when the forge is opened up to the general public, I don't think we want
every user to be able to edit labels.

  * The addition of the following labels:
>   * * cannot reproduce
>

That should be in bugzilla not a pull request, shouldn't it? A PR is not
something you reproduce.

  * * not needed anymore
>

Why not just close the PR?

  * * ready to merge
>


Isn't that "approved" by a reviewer?

I suppose it could be approved by somebody who isn't actually a GCC
maintainer, which is different from "approved to be merged".


  * * waiting on author
>

Do we need labels for that?

  * * waiting for review


I think you can already find that without labels.

  * * waiting for info
>
> Maybe we would need a different name for the last one to specify that
> this is waiting for info from the reviewer, e.g. when I ask questions to
> get more details about something.
>
> What are your thoughts on this?
>

I think the fact it's still open means it's still waiting for somebody to
respond. Do we really need labels for each type of "waiting? Other projects
don't seem to need these labels in GitHub repos I work on.




> Thanks.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/forge/attachments/20241206/d7c54885/attachment.htm>