[PATCH] app.ini: re-enable attachments

[Mark Wielaard]

Hi Arsen,

On Wed, Oct 23, 2024 at 09:46:32PM +0200, Arsen Arsenović wrote:
> It appears to be the case that disabling attachments causes a Forgejo
> bug to manifest, where, in repo-legacy.js:saveAndRefresh, dropzoneInst
> gets the value 'undefined', breaking comment editing.
> 
> Comment attachments are generally useful also, so let's just re-enable
> them.
> 
> I've reduced the MAX_SIZE from its default of 2048 down to 16.  The unit
> is MB per documentation, so this is probably fine, if not
> excess (thinking of really large dumps or perhaps entire executables
> produced during patch discussion).

Applied, installed and restarted forgejo.

But I think such attachements really should go into the bugzilla issue.

> ---
> I've not made a local deployment to test these values, or whether that
> bug goes away, sorry!

See https://sourceware.org/cgit/forge/tree/SETUP
But we really should write a SETUP.QUICK that people can use for a
quick and dirty setup to test changes locally which don't depend on
having a full install.

> I'm putting this together quickly as an attempt to fix the noted-on-IRC
> impossibility to edit comments after posting them.
> 
> Should it work, we should tell Forgejo hackers about the bug.

Yes, thanks.

Cheers,

Mark