[PATCH] stacktrace: fix a C23-ism in sigint_handler

Sam James sam@gentoo.org
Sat Feb 7 21:32:45 GMT 2026


Mark Wielaard <mark@klomp.org> writes:

> Hi Sam,
>
> On Sat, Feb 07, 2026 at 02:05:16AM +0000, Sam James wrote:
>> Mark Wielaard <mark@klomp.org> writes:
>> > Thanks, I forgot about that. The attached patch contains a configure
>> > check to make sure -Wmissing-parameter-name is available. Adding it
>> > did catch the same issue with gcc.
>> 
>> LGTM. There is -Wdeprecated-non-prototype and also -Wfree-labels for
>> some other C23ish issues.
>
> The attached patch adds those warning too. But they didn't catch any
> issues in the current codebase.

LGTM also. Thanks for handling it!

Reviewed-by: Sam James <sam@gentoo.org>

>
>> Reviewed-by: Sam James <sam@gentoo.org>
>
> Thanks. Pushed with that tag.
>
> Cheers,
>
> Mark
>
> [2. text/plain; 0001-configure-Add-Wdeprecated-non-prototype-and-Wfree-la.patch]...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 418 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/elfutils-devel/attachments/20260207/c0337116/attachment.sig>


More information about the Elfutils-devel mailing list