[PATCH 12/15 v4] Add tests/run-eu-search-cfi.sh

[Mark Wielaard]

Hi Aaron,

On Sun, 2025-01-19 at 22:20 -0500, Aaron Merey wrote:
> From: Heather McIntyre <hsm2@rice.edu>
> 
> 	* tests/.gitignore: Add eu_search_cfi.
> 	* tests/Makefile.am: Add eu_search_cfi, run-eu-search-cfi.sh.
>         * tests/eu_search_cfi.c: New file.
> 	* tests/run-eu-search-cfi.sh: New file.

note odd indentation above.

But I really like this test. Looks good.

> @@ -874,6 +876,8 @@ nvidia_extended_linemap_libdw_LDADD = $(libelf) $(libdw)
>  elf_print_reloc_syms_LDADD = $(libelf)
>  cu_dwp_section_info_LDADD = $(libdw)
>  declfiles_LDADD = $(libdw)
> +eu_search_cfi_LDFLAGS = $(if $(filter undefined,$(origin USE_LOCKS)),-pthread) $(AM_LDFLAGS)
> +eu_search_cfi_LDADD = $(libeu) $(libelf) $(libdw)

The filter works and should be fine. But I think you can simply always
use -pthread. There is no harm in always using it and you already have
the check_thread_safety_enabled check to see if you want to run it.

Cheers,

Mark